Bug 480177

Summary: Add metadata dropdown is too annoying
Product: [Applications] Elisa Reporter: Emir SARI <emir_sari>
Component: generalAssignee: Matthieu Gallien <matthieu_gallien>
Status: RESOLVED FIXED    
Severity: normal CC: jackhill3103, nate
Priority: NOR Keywords: usability
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Neon   
OS: All   
Latest Commit: https://invent.kde.org/multimedia/elisa/-/commit/fbdc73eb004ff3b74e23e7d104cf6a64e16b8889 Version Fixed/Implemented In:
Sentry Crash Report:

Description Emir SARI 2024-01-22 16:21:34 UTC 
Let's say, I have a file without metadata. I have all the information at hand. I want to fill it out.

When I go into the edit mode, I need to click the dropdown and select what I want to add ONE BY ONE. This is borderline hostile behaviour. Why not have all the metadata fields in the open like EVERY OTHER music player out there? So that I could just TAB my way in?

Another anti-UX behaviour is that, when I add a new field from the drop-down, it is downright impossible to understand that a field is added to the very bottom. Also the behaviour is buggy in itself, after clicking the drop-down, and selecting a field, a poorly padded and poorly positioned error overlay, that says the data is invalid and it's empty, messes with the layout even more.

Even if I add all the fields one by one, I need to scroll to see all the fields, is very annoying. There should be a simple way to position everything nicely like those old boring programs with gazillions of text fields next to each other. You know, those you enter your personal details and info about your previous 10 generation of family. Now, that is good layout (read it in Jerry Seinfeld voice).

KDE neon Unstable, Elisa Git master
Comment 1 Bug Janitor Service 2024-10-23 19:57:37 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/633
Comment 2 Jack Hill 2024-10-28 19:34:41 UTC 
Git commit fbdc73eb004ff3b74e23e7d104cf6a64e16b8889 by Jack Hill.
Committed on 26/10/2024 at 17:19.
Pushed by jackh into branch 'master'.

Rework track metadata editor form

Instead adding tags via a dropdown box, now we place a button besides each
tag label.

M  +19   -3    autotests/trackmetadatamodeltest.cpp
M  +2    -31   src/models/editabletrackmetadatamodel.cpp
M  +3    -17   src/models/editabletrackmetadatamodel.h
M  +39   -55   src/models/trackmetadatamodel.cpp
M  +2    -1    src/models/trackmetadatamodel.h
M  +2    -0    src/qml/ContextView.qml
M  +16   -3    src/qml/MediaTrackMetadataDelegate.qml
M  +9    -16   src/qml/MediaTrackMetadataForm.qml

https://invent.kde.org/multimedia/elisa/-/commit/fbdc73eb004ff3b74e23e7d104cf6a64e16b8889