| Summary: | Crash in SidebarMode::eventFilter() after removing ALT+TAB shortcut | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | duha.bugs |
| Component: | sidebarview | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | akselmo, nate, notmart |
| Priority: | NOR | Keywords: | drkonqi, qt6 |
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/systemsettings/-/commit/d14df9091ec7d0d676734614d936f85d5bdac55e | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | BT_GIT_MASTER | ||
|
Description
duha.bugs
2024-01-18 17:59:54 UTC
Created attachment 165017 [details]
BT_GIT_MASTER
Can also reproduce on git master. BT attached.
Can reproduce Operating System: Fedora Linux 39 KDE Plasma Version: 6.0.80 KDE Frameworks Version: 6.0.0 Qt Version: 6.6.0 Kernel Version: 6.7.3-200.fc39.x86_64 (64-bit) Graphics Platform: Wayland Processors: 12 × AMD Ryzen 5 3600 6-Core Processor Memory: 15.5 GiB of RAM Graphics Processor: AMD Radeon RX 6600 A possibly relevant merge request was started @ https://invent.kde.org/plasma/systemsettings/-/merge_requests/293 Git commit 4ba7b0b1e81543600b97afc2d3bfe67dd9b6f87e by Akseli Lahtinen. Committed on 06/02/2024 at 11:54. Pushed by akselmo into branch 'master'. SideBarMode: return false in eventFilter if qqw is nullptr If user presses Alt+Tab in a view that has both `QtWidgets` and `QtQuickWidgets`, and Alt+Tab is not set as a shortcut, systemsettings will crash. This seems to be because Alt key activates the quick shortcuts in `QtWidgets` (the thing that underlines one letter from an element) and the active element is then not a `QtQuickWidget`, which is then `nullptr`, and crashes systemsettings when `nullptr` is sent with `sendEvent` M +7 -0 app/sidebar/SidebarMode.cpp https://invent.kde.org/plasma/systemsettings/-/commit/4ba7b0b1e81543600b97afc2d3bfe67dd9b6f87e Git commit d14df9091ec7d0d676734614d936f85d5bdac55e by Akseli Lahtinen. Committed on 06/02/2024 at 11:55. Pushed by akselmo into branch 'Plasma/6.0'. SideBarMode: return false in eventFilter if qqw is nullptr If user presses Alt+Tab in a view that has both `QtWidgets` and `QtQuickWidgets`, and Alt+Tab is not set as a shortcut, systemsettings will crash. This seems to be because Alt key activates the quick shortcuts in `QtWidgets` (the thing that underlines one letter from an element) and the active element is then not a `QtQuickWidget`, which is then `nullptr`, and crashes systemsettings when `nullptr` is sent with `sendEvent` (cherry picked from commit 4ba7b0b1e81543600b97afc2d3bfe67dd9b6f87e) M +7 -0 app/sidebar/SidebarMode.cpp https://invent.kde.org/plasma/systemsettings/-/commit/d14df9091ec7d0d676734614d936f85d5bdac55e |