Bug 479970

Summary: Clicking on "Configure Icons and Toolbars..." button again doesn't dismiss the pop-up
Product: [Applications] systemsettings Reporter: guimarcalsilva
Component: kcm_styleAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: agurenko, mail, nate
Priority: NOR Keywords: qt6
Version First Reported In: master   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/plasma-workspace/-/commit/d3a4ee40b0e73203ed8b10a0c5d1e3b3e16c3173 Version Fixed/Implemented In: 6.0
Sentry Crash Report:

Description guimarcalsilva 2024-01-18 01:22:13 UTC 
SUMMARY
Congratulations! Plasma 6 is getting pretty stable, so this is just a nitpick.
It's possible to click on "Configure Icons and Toolbars..." after the overlay sheet opens, but nothing happens. It would be nice if the user could dismiss the pop-up by clicking on it again instead of clicking the X button. 

STEPS TO REPRODUCE
1. Open kcm_style
2. Click on "Configure Icons and Toolbars..." more than once

OBSERVED RESULT
Nothing happens

EXPECTED RESULT
Clicking on it again could dismiss the pop-up

SOFTWARE/OS VERSIONS
KDE Plasma Version: 6.0.80
KDE Frameworks Version: 5.249.0
Qt Version: 6.6.1
Comment 1 Nate Graham 2024-01-18 20:13:47 UTC 
Can reproduce.
Comment 2 Bug Janitor Service 2024-01-18 20:32:00 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3783
Comment 3 Nate Graham 2024-01-21 16:19:51 UTC 
Git commit 8f6e7eedacc02ad16660a7e9eb1a17cda0dd2d90 by Nate Graham.
Committed on 21/01/2024 at 16:36.
Pushed by ngraham into branch 'master'.

kcms/style: close popup on second click of the button that opened it

Right now the button unconditionally opens the popup, but it can still
be clicked while the popup is open, and in this case it does nothing.
Instead, close the popup.
FIXED-IN: 6.0

M  +21   -3    kcms/style/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/8f6e7eedacc02ad16660a7e9eb1a17cda0dd2d90
Comment 4 Nate Graham 2024-01-21 16:59:07 UTC 
Git commit d3a4ee40b0e73203ed8b10a0c5d1e3b3e16c3173 by Nate Graham.
Committed on 21/01/2024 at 17:59.
Pushed by ngraham into branch 'Plasma/6.0'.

kcms/style: close popup on second click of the button that opened it

Right now the button unconditionally opens the popup, but it can still
be clicked while the popup is open, and in this case it does nothing.
Instead, close the popup.
FIXED-IN: 6.0


(cherry picked from commit 8f6e7eedacc02ad16660a7e9eb1a17cda0dd2d90)

M  +21   -3    kcms/style/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/d3a4ee40b0e73203ed8b10a0c5d1e3b3e16c3173