Bug 479969

Summary: It's possible to open multiple "Configure Launch Feedback..." pop-ups
Product: [Applications] systemsettings Reporter: guimarcalsilva
Component: kcm_cursorthemeAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: normal Keywords: qt6, regression
Priority: NOR    
Version First Reported In: master   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/plasma-workspace/-/commit/2390b0b07e6b5cebdc3bd3b44660a1c054cc69b1 Version Fixed/Implemented In: 6.0
Sentry Crash Report:

Description guimarcalsilva 2024-01-18 01:14:10 UTC 
SUMMARY
Congratulations! Plasma 6 is getting pretty stable, so this is just a nitpick.
Now that the buttons are on the header, they don't get obscured when an overlay sheet is open, which means the user can click "Configure Launch Feedback..." multiple times and open many pages. Maybe clicking it again should close the pop-up.

STEPS TO REPRODUCE
1. Open kcm_cursortheme
2. Click on "Configure Launch Feedback..." multiple times

OBSERVED RESULT
It will open multiple times on top of one another

EXPECTED RESULT
Clicking the button again should dismiss the pop-up. If that's not possible, maybe the header should get obscured like before, so clicking on it automatically dismisses the pop-up before the user has the chance to click the button.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 6.0.80
KDE Frameworks Version: 5.249.0
Qt Version: 6.6.1
Comment 1 Bug Janitor Service 2024-01-18 12:43:26 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3777
Comment 2 Fushan Wen 2024-01-18 13:11:19 UTC 
Git commit 1daa1bfa5ba13d6d3a9c171ad0f3a206b8caff9c by Fushan Wen.
Committed on 18/01/2024 at 13:41.
Pushed by fusionfuture into branch 'master'.

kcms/cursortheme: only create LaunchFeedbackDialog once

This adds a property to keep the created instance.

Also adds a test to ensure the dialog can be opened.
FIXED-IN: 6.0

M  +4    -0    appiumtests/kcm_cursortheme_test.py
M  +0    -4    kcms/cursortheme/ui/LaunchFeedbackDialog.qml
M  +10   -5    kcms/cursortheme/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/1daa1bfa5ba13d6d3a9c171ad0f3a206b8caff9c
Comment 3 Fushan Wen 2024-01-18 15:52:39 UTC 
Git commit 2390b0b07e6b5cebdc3bd3b44660a1c054cc69b1 by Fushan Wen.
Committed on 18/01/2024 at 14:13.
Pushed by fusionfuture into branch 'Plasma/6.0'.

kcms/cursortheme: only create LaunchFeedbackDialog once

This adds a property to keep the created instance.

Also adds a test to ensure the dialog can be opened.
FIXED-IN: 6.0


(cherry picked from commit 1daa1bfa5ba13d6d3a9c171ad0f3a206b8caff9c)

M  +4    -0    appiumtests/kcm_cursortheme_test.py
M  +0    -4    kcms/cursortheme/ui/LaunchFeedbackDialog.qml
M  +10   -5    kcms/cursortheme/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/2390b0b07e6b5cebdc3bd3b44660a1c054cc69b1