Summary: | Drag and drop opens hovered files | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | sasori.nami |
Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | akselmo, kde, kfm-devel, nate |
Priority: | HI | ||
Version: | 23.08.4 | ||
Target Milestone: | --- | ||
Platform: | Manjaro | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/system/dolphin/-/commit/803bbd1ae191a89ffdb3889acb6621431525f96d | Version Fixed In: | 24.05 |
Sentry Crash Report: |
Description
sasori.nami
2024-01-17 20:20:30 UTC
Also to note: if I disable "Dolphin settings > Navigation > Open folders during drag operations", the bug is fixed, but I also lose the ability to open directories as I hover them. Maybe a check on the mime-type is missing in the code that offers this feature... After some perusing of the codebase, I think this might be a regression due to https://github.com/KDE/dolphin/commit/9967a5cdee3ca7027871a6b2b640e94435d6b7af#diff-46d537eafe5dbb0ecc4080dd9ee5eefbb7442d29997063b37d91f12817dfe933L537 Bear in mind, I'm just an enthusiast Python/Qt dev (via PySide). I can barely read C++. I might be completely wrong. Can reproduce on Plasma 6 as well. Operating System: Fedora Linux 39 KDE Plasma Version: 6.0.80 KDE Frameworks Version: 6.0.0 Qt Version: 6.6.0 Kernel Version: 6.6.13-200.fc39.x86_64 (64-bit) Graphics Platform: Wayland Processors: 12 × AMD Ryzen 5 3600 6-Core Processor Memory: 15.5 GiB of RAM Graphics Processor: AMD Radeon RX 6600 A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/711 Git commit 803bbd1ae191a89ffdb3889acb6621431525f96d by Akseli Lahtinen. Committed on 08/03/2024 at 11:37. Pushed by akselmo into branch 'master'. Start autoActivationTimer only if hovering over a directory Before starting autoActivationTimer, check that we're hovering the item on top of a directory. If we don't check for it, the the autoActivationTimer will try to open the hovered item in it's default application, which can be distracting and break the actual action the user was trying to do, like moving the file to a directory. M +11 -0 src/kitemviews/kfileitemmodel.cpp M +2 -0 src/kitemviews/kfileitemmodel.h M +2 -1 src/kitemviews/kitemlistcontroller.cpp M +6 -0 src/kitemviews/kitemmodelbase.cpp M +9 -0 src/kitemviews/kitemmodelbase.h https://invent.kde.org/system/dolphin/-/commit/803bbd1ae191a89ffdb3889acb6621431525f96d Thank you :) |