| Summary: | Plasma 6's SNI implementation doesn't respect the IconThemePath property | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Ilya Bizyaev <bizyaev> |
| Component: | System Tray widget | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | anon.immety, arkabhuiyancsedu, firew4lker, isma.af, materka, mmbossoni, monsoon.cl, nate, nicolas.fella, nicolas, patvr, paulatz, qydwhotmail, shalokshalom, sighunter, valaquarus |
| Priority: | HI | Keywords: | qt6, regression |
| Version: | 5.92.0 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=482645 | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/976575921d2a1bbd2551afba335be08ebf0f2a25 | Version Fixed In: | 6.0.1 |
| Sentry Crash Report: | |||
| Attachments: |
missing icon in 6.0.1
Icons in System Tray look OK but a couple of them are very dim |
||
|
Description
Ilya Bizyaev
2024-01-12 23:22:18 UTC
*** Bug 481682 has been marked as a duplicate of this bug. *** *** Bug 482201 has been marked as a duplicate of this bug. *** *** Bug 481999 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4002 Git commit a713f2351ad7f9ea3b43d2ec436ff1f20d6c036a by Nate Graham, on behalf of Nicolas Fella. Committed on 04/03/2024 at 23:34. Pushed by ngraham into branch 'master'. applets/systemtray: Prefer Icon over IconName The systemtray has a custom KIconLoader in order to make the SNI's IconThemePath work. When passing an icon name to Kirigami.Icon we skip that. Instead prefer the Icon role from the model, which goes through the custom loader This restores the logic to how it was before d31b985b6ba3d68b2ac018839864b305b6780574. FIXED-IN: 6.0.1 M +1 -1 applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/a713f2351ad7f9ea3b43d2ec436ff1f20d6c036a The commit fixes this issue, but reintroduces coloring problems for monochrome icons Git commit 976575921d2a1bbd2551afba335be08ebf0f2a25 by Nate Graham, on behalf of Nicolas Fella. Committed on 04/03/2024 at 23:39. Pushed by ngraham into branch 'Plasma/6.0'. applets/systemtray: Prefer Icon over IconName The systemtray has a custom KIconLoader in order to make the SNI's IconThemePath work. When passing an icon name to Kirigami.Icon we skip that. Instead prefer the Icon role from the model, which goes through the custom loader This restores the logic to how it was before d31b985b6ba3d68b2ac018839864b305b6780574. FIXED-IN: 6.0.1 (cherry picked from commit a713f2351ad7f9ea3b43d2ec436ff1f20d6c036a) 34efcc14 [applets/systemtray] Prefer Icon over IconName M +1 -1 applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/976575921d2a1bbd2551afba335be08ebf0f2a25 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4004 *** Bug 482522 has been marked as a duplicate of this bug. *** *** Bug 482610 has been marked as a duplicate of this bug. *** I have also noticed missing icons (oxygen theme) in the tray. No Bluetooth, Notifications, Vault, Brightness and Color icons. Those icons seems to be missing from everywhere (eg System Settings). Is it the same bug? *** Bug 482962 has been marked as a duplicate of this bug. *** I am using Nobara Linux and the plasma version is 6.0.1. Unfortunately, I am seeing the fix yet. Is there something we need to do to fix the issue? *** Bug 483049 has been marked as a duplicate of this bug. *** At least two people on 6.0.1 confirm that this bug is still active. Tested with QBittorrent. NixOS and Arch Linux. Created attachment 166894 [details]
missing icon in 6.0.1
Sorry, we failed. That issue here is indeed solved and we encountered an independent problem in Qbittorrent. Closing A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4039 Git commit 257ccabc526ab7f4d5ca12758c1e29af35b048ca by Nicolas Fella. Committed on 11/03/2024 at 17:01. Pushed by nicolasfella into branch 'master'. [applets/systemtray] Load icons with Plasma palette When using Breeze Twilight, i.e. dark Plasma and lights apps, we need to color the icons with the Plasma colors Related: bug 482645 M +24 -6 applets/systemtray/statusnotifieritemsource.cpp M +1 -0 applets/systemtray/statusnotifieritemsource.h https://invent.kde.org/plasma/plasma-workspace/-/commit/257ccabc526ab7f4d5ca12758c1e29af35b048ca Git commit d73c6c4bb938bbd252c5bd69cc93862cba554e32 by Nicolas Fella. Committed on 11/03/2024 at 17:06. Pushed by nicolasfella into branch 'Plasma/6.0'. [applets/systemtray] Load icons with Plasma palette When using Breeze Twilight, i.e. dark Plasma and lights apps, we need to color the icons with the Plasma colors To achieve this always set the current palette on the icon loader, which means always creating a custom loader For the icons in the context menu we want the application palette, so create a separate loader for that Related: bug 482645 M +56 -24 applets/systemtray/statusnotifieritemsource.cpp M +2 -0 applets/systemtray/statusnotifieritemsource.h https://invent.kde.org/plasma/plasma-workspace/-/commit/d73c6c4bb938bbd252c5bd69cc93862cba554e32 Not sure if you want feedback from a user but here it is. I package update every day and have been seeing the icons in the system tray and expanded tray all displaying properly now and for the past few days. This is using the Breeze, Breeze Dark as well as contributor icons as well. The only thing I would comment on is that the Printer and Weather icons in the system tray are pretty dim. See attachment userSystemTraySnapshot_20240327 Let me know if I should not be commenting here Created attachment 167830 [details]
Icons in System Tray look OK but a couple of them are very dim
As mentioned in ticket comment
The breeze icons for printer and power management look correct here. This looks like the third-party icon theme is not using the right color roles for some icons. Please report this to the theme author. |