Bug 479584

Summary: The include file /usr/include/kwin/effect/xcb.h is missing in kwin-devel
Product: [Plasma] kwin Reporter: andriy.parhomenko
Component: coreAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: fanzhuyifan
Priority: NOR Keywords: qt6
Version First Reported In: 5.91.0   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description andriy.parhomenko 2024-01-09 20:32:07 UTC
SUMMARY
I included the /usr/include/kwin/utils/xcbutils.h in a project but it fails because the other include dependent on it is missing /usr/include/kwin/effect/xcb.h from the package kwin-devel

STEPS TO REPRODUCE
1. Build a project with /usr/include/kwin/utils/xcbutils.h

OBSERVED RESULT
In file included from /home/parhom/blur/blur.cpp:20:
/usr/include/kwin/utils/xcbutils.h:12:10: fatal error: effect/xcb.h: No such file or directory
   12 | #include "effect/xcb.h"
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.

EXPECTED RESULT
To not throw an error

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Fedora Rawhide
KDE Plasma Version: 5.91.0
KDE Frameworks Version: 5.247.0
Qt Version: 6.6.1

ADDITIONAL INFORMATION
All utils headers were downloaded manually from kwin gitlab repo, because commit #58a2a3cf (utils: install all the headers) is not yet present in Fedora Rawhide packages.
Comment 1 fanzhuyifan 2024-01-09 20:49:21 UTC
As you mentioned, the relevant commit has already been merged. Since it is not yet present in Fedora Rawhide packages, you will either have to compile and install kwin from source, or contact the Fedora Rawhide package maintainers.

https://invent.kde.org/plasma/kwin/-/commit/58a2a3cf8141f02f53cac241724227f5e53c2367?merge_request_iid=4854
Comment 2 andriy.parhomenko 2024-01-09 21:14:21 UTC
(In reply to fanzhuyifan from comment #1)
> As you mentioned, the relevant commit has already been merged. Since it is
> not yet present in Fedora Rawhide packages, you will either have to compile
> and install kwin from source, or contact the Fedora Rawhide package
> maintainers.
> 
> https://invent.kde.org/plasma/kwin/-/commit/
> 58a2a3cf8141f02f53cac241724227f5e53c2367?merge_request_iid=4854

That commit does not include effect/xcb.h file, but it is needed by utils/xcbutils.h. That was the point of this report.
Comment 3 fanzhuyifan 2024-01-09 21:28:03 UTC
Ahh I see. Sorry!
Comment 4 Bug Janitor Service 2024-01-10 08:54:54 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/4863
Comment 5 Vlad Zahorodnii 2024-01-11 09:20:20 UTC
Git commit 3a5ba58a45c9ff8ae9b2f62de5a970280b634f38 by Vlad Zahorodnii.
Committed on 11/01/2024 at 10:10.
Pushed by vladz into branch 'master'.

effect: Install xcb.h

M  +1    -0    src/CMakeLists.txt

https://invent.kde.org/plasma/kwin/-/commit/3a5ba58a45c9ff8ae9b2f62de5a970280b634f38
Comment 6 Vlad Zahorodnii 2024-01-12 10:20:22 UTC
Git commit fce26936d043e96896ad86565d4168ba4a32d787 by Vlad Zahorodnii.
Committed on 12/01/2024 at 11:06.
Pushed by vladz into branch 'Plasma/6.0'.

effect: Install xcb.h


(cherry picked from commit 3a5ba58a45c9ff8ae9b2f62de5a970280b634f38)

M  +1    -0    src/CMakeLists.txt

https://invent.kde.org/plasma/kwin/-/commit/fce26936d043e96896ad86565d4168ba4a32d787