Bug 479512

Summary: Renaming tags with many items and hitting No on "Write now?" pop-up is not written automatically to file
Product: [Applications] digikam Reporter: Paul Krause <paul_krause_1980>
Component: Tags-ManagerAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: metzpinguin
Priority: NOR    
Version First Reported In: 8.3.0   
Target Milestone: ---   
Platform: Appimage   
OS: Linux   
Latest Commit: https://invent.kde.org/graphics/digikam/-/commit/b912f90a55e9e3d60e582e638c0606a38a989d52 Version Fixed/Implemented In: 8.3.0
Sentry Crash Report:

Description Paul Krause 2024-01-07 16:52:15 UTC 
SUMMARY
See steps and observed


STEPS TO REPRODUCE
1. Enable writing tags to files (Tabs Behavior and Advanced in Settings - Metadata)
2. Move, or rename, a tag with a large amount of assigned items (prob. 100 and prop. merging is the same)
3. Hit no on the "Do you want to write the metadata now?" pop-up.

OBSERVED RESULT
Nothing happens.
Thus the change in tags is only written to the files if something else triggers a metadata write for them.
This leaves an inconsistency between the database and the files and can lead to data loss (if the files are moved around, already happened to me).

EXPECTED RESULT
The tags are written to the files, at some time, without further user interaction.
A logical option would be the metadata writing queue, especially if lazy synchronization is enabled anyway.

SOFTWARE/OS VERSIONS
digiKam-8.3.0-20240107T133949-x86-64.appimage
Comment 1 Maik Qualmann 2024-01-07 17:47:06 UTC 
Git commit b912f90a55e9e3d60e582e638c0606a38a989d52 by Maik Qualmann.
Committed on 07/01/2024 at 18:46.
Pushed by mqualmann into branch 'master'.

use Lazy Sync when renaming or moving tags
FIXED-IN: 8.3.0

M  +1    -1    NEWS
M  +1    -0    core/libs/album/manager/albummanager_p.h
M  +7    -0    core/libs/album/manager/albummanager_talbum.cpp
M  +15   -0    core/libs/fileactionmanager/metadatahubmngr.cpp
M  +1    -0    core/libs/fileactionmanager/metadatahubmngr.h

https://invent.kde.org/graphics/digikam/-/commit/b912f90a55e9e3d60e582e638c0606a38a989d52
Comment 2 Maik Qualmann 2024-01-07 17:50:16 UTC 
If Lazy Sync is not enabled and you select "No", then you will need to synchronize the metadata via the maintenance tool or via the albums and items synchronization.

Maik