Bug 479329

Summary: Cannot select processes in the tree view
Product: [Applications] plasma-systemmonitor Reporter: Ilya Bizyaev <bizyaev>
Component: generalAssignee: KSysGuard Developers <ksysguard-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: ahiemstra, nate, notmart, plasma-bugs-null
Priority: NOR Keywords: qt6, usability
Version First Reported In: 5.92.0   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/38311d798afd046b841f27436f336b3348da38e7 Version Fixed/Implemented In:
Sentry Crash Report:

Description Ilya Bizyaev 2024-01-02 23:37:03 UTC 
SUMMARY
In the list view, clicking any process selects it. In the tree view, this only works for the root processes (systemd or kthreadd). Right-clicking a process in the tree view offers to “Terminate 0 processes”, i.e. also does not select them.


STEPS TO REPRODUCE
1. System Monitor > Processes
2. Switch to the tree view mode
3. Left-click or right-click a process other than the tree root

OBSERVED RESULT
Cannot select or terminate the process.

EXPECTED RESULT
Can select or terminate the process.

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20231226
KDE Plasma Version: 5.91.90
KDE Frameworks Version: 5.248.0
Qt Version: 6.6.1
Graphics Platform: Wayland

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2024-01-11 22:51:30 UTC 
Can reproduce.
Comment 2 Bug Janitor Service 2024-02-01 15:51:10 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/251
Comment 3 Arjen Hiemstra 2024-02-14 10:53:15 UTC 
Git commit b81ec13926f90dfcd465d806182fd9e7176d0182 by Arjen Hiemstra.
Committed on 13/02/2024 at 11:32.
Pushed by ahiemstra into branch 'master'.

table: Use upstream table selection behavior

Rather than manually implementing table selection behaviors, use those
provided by upstream TableView. This ensures things work in tree view
mode, it gives us interrupted selection and generally improves behavior.

M  +0    -34   src/table/BaseCellDelegate.qml
M  +26   -84   src/table/BaseTableView.qml

https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/b81ec13926f90dfcd465d806182fd9e7176d0182
Comment 4 Arjen Hiemstra 2024-02-14 11:02:08 UTC 
Git commit 38311d798afd046b841f27436f336b3348da38e7 by Arjen Hiemstra.
Committed on 14/02/2024 at 10:57.
Pushed by ahiemstra into branch 'Plasma/6.0'.

table: Use upstream table selection behavior

Rather than manually implementing table selection behaviors, use those
provided by upstream TableView. This ensures things work in tree view
mode, it gives us interrupted selection and generally improves behavior.


(cherry picked from commit b81ec13926f90dfcd465d806182fd9e7176d0182)

M  +0    -34   src/table/BaseCellDelegate.qml
M  +26   -84   src/table/BaseTableView.qml

https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/38311d798afd046b841f27436f336b3348da38e7