Summary: | With Qt 6.7, no "Add to favorites" and "Remove from favorites" menu items | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Jin Liu <ad.liu.jin> |
Component: | Application Launcher (Kickoff) | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | arojas, bugseforuns, dominik.klementowski, eric1, lukas, me, mikel5764, nate, nicolas.fella, noahadvs, witabrewis |
Priority: | NOR | Keywords: | qt6 |
Version: | 5.93.0 | ||
Target Milestone: | 1.0 | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/-/commit/dafe25df477bdb642b3217f4d488dcd2af87b281 | Version Fixed In: | 6.0 |
Description
Jin Liu
2023-12-30 06:50:45 UTC
I suspect https://code.qt.io/cgit/qt/qtdeclarative.git/commit/?id=b9bfdea0e2c6721d2306af0ecc44f88da9988957 caused it Works for me in Qt 6.6, so I guess it's a Qt 6.7 regression. (In reply to Nicolas Fella from comment #1) > I suspect > https://code.qt.io/cgit/qt/qtdeclarative.git/commit/ > ?id=b9bfdea0e2c6721d2306af0ecc44f88da9988957 caused it Confirmed. Somehow model.actionList seems to be immutable. This fixes it for me, but i don't know if it's the right fix (hence not creating a PR) --- a/applets/kickoff/package/contents/ui/AbstractKickoffItemDelegate.qml +++ b/applets/kickoff/package/contents/ui/AbstractKickoffItemDelegate.qml @@ -58,7 +58,7 @@ T.ItemDelegate { function openActionMenu(x = undefined, y = undefined) { if (!hasActionList) { return; } - let actions = model.actionList; + var actions = [].concat(model.actionList); const favoriteActions = Tools.createFavoriteActions( i18n, //i18n() function callback view.model.favoritesModel, *** Bug 480625 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2032 I can confirm the issue on RC 2 and that the patch from https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2032 fixes it for me. Git commit 2bc049f792725917f4b262e79eabadbdefc901d6 by Fushan Wen, on behalf of Darshan Phaldesai. Committed on 12/02/2024 at 01:02. Pushed by fusionfuture into branch 'master'. applets/kickoff: fix favourites actions for Kickoff in QT 6.7 QT 6.7 makes actionsList immutable and thus `push()` fails on it. FIXED-IN: 6.0 M +1 -1 applets/kickoff/package/contents/ui/AbstractKickoffItemDelegate.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/2bc049f792725917f4b262e79eabadbdefc901d6 Git commit dafe25df477bdb642b3217f4d488dcd2af87b281 by Fushan Wen, on behalf of Darshan Phaldesai. Committed on 12/02/2024 at 01:03. Pushed by fusionfuture into branch 'Plasma/6.0'. applets/kickoff: fix favourites actions for Kickoff in QT 6.7 QT 6.7 makes actionsList immutable and thus `push()` fails on it. FIXED-IN: 6.0 (cherry picked from commit 2bc049f792725917f4b262e79eabadbdefc901d6) M +1 -1 applets/kickoff/package/contents/ui/AbstractKickoffItemDelegate.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/dafe25df477bdb642b3217f4d488dcd2af87b281 *** Bug 481447 has been marked as a duplicate of this bug. *** |