Bug 479053

Summary: Save As button opens "Open File" dialog instead of Save
Product: [Applications] NeoChat Reporter: Justin Zobel <justin>
Component: GeneralAssignee: Tobias Fella <fella>
Status: RESOLVED FIXED    
Severity: normal CC: carl, james.h.graham, ulterno
Priority: NOR    
Version First Reported In: 24.01.85   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/network/neochat/-/commit/d26a6916478b9eb76c9d09a675c74ce6a04df3cd Version Fixed/Implemented In:
Sentry Crash Report:

Description Justin Zobel 2023-12-27 03:00:11 UTC 
STEPS TO REPRODUCE
1. Attempt to save an image using the button on the toolbar

OBSERVED RESULT
Open File dialog is shown and you cannot save the image

EXPECTED RESULT
Save File dialog is shown and can save the image
Comment 1 James Graham 2023-12-28 13:38:51 UTC 
Can confirm. Just to double check that you mean in the image maximize view as that is where I see it
Comment 2 ulterno 2024-02-11 06:49:38 UTC 
Not a recent regression.
Same bug exists in 23.08.4
Comment 3 Bug Janitor Service 2024-02-11 07:54:00 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/1561
Comment 4 Bug Janitor Service 2024-02-11 07:57:49 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/1562
Comment 5 ulterno 2024-02-11 08:04:43 UTC 
Fixed for branch release/23.08
https://invent.kde.org/network/neochat/-/merge_requests/1562

Hopefully someone can check it out for master and get it there.

Note: It seems there might be a lot of erroneous variable name issues in the QML code. It would be good to find a way to autodetect them.
Comment 6 ulterno 2024-02-11 08:05:34 UTC 
(In reply to Bug Janitor Service from comment #3)
> A possibly relevant merge request was started @
> https://invent.kde.org/network/neochat/-/merge_requests/1561

Sorry, this was a wrong one.
Selected the wrong branch by mistake.
Comment 7 Tobias Fella 2024-02-11 12:17:42 UTC 
Git commit d26a6916478b9eb76c9d09a675c74ce6a04df3cd by Tobias Fella, on behalf of Ulterno Ω*.
Committed on 11/02/2024 at 12:17.
Pushed by tfella into branch 'release/23.08'.

Fix saving images

Fixed variable names and scope resolution for saveAsDialog in NeochatMaximizeComponent 

Hence, correcting the File Dialog type and making the downloadFile function work.

M  +2    -2    src/qml/Component/NeochatMaximizeComponent.qml

https://invent.kde.org/network/neochat/-/commit/d26a6916478b9eb76c9d09a675c74ce6a04df3cd