Bug 479019

Summary: Support non-default settings highlighting feature
Product: [Applications] systemsettings Reporter: Patrick Silva <bugseforuns>
Component: kcm_kwinxwaylandAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: wishlist CC: 4wy78uwh, aleixpol, nate
Priority: NOR    
Version: 5.27.10   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/kwin/-/commit/623a1939d21d2e6e57db8dc9afbef38c2e163304 Version Fixed In: 6.2.0
Sentry Crash Report:

Description Patrick Silva 2023-12-26 10:42:59 UTC 
STEPS TO REPRODUCE
1. use Wayland
2. open Legacy X11 App Support KCM
3. select any option but "Never"

OBSERVED RESULT
selected radio button is not highlighted in orange

EXPECTED RESULT
selected radio button is highlighted in orange

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.91.90
KDE Frameworks Version: 5.248.0
Qt Version: 6.6.1
Graphics Platform: Wayland
Comment 1 Bug Janitor Service 2024-09-20 11:07:42 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/6435
Comment 2 Vlad Zahorodnii 2024-09-21 13:12:01 UTC 
Git commit a4856a015b2a72d1ae9ff53799a7d16b1f6e3022 by Vlad Zahorodnii, on behalf of David Edmundson.
Committed on 21/09/2024 at 13:01.
Pushed by vladz into branch 'master'.

kcms/xwayland: Add settingStateBindings

This adds the orange highlights of which settings are changed within the
KCM.

The KCFG file is modified as QML bindings automatically convert
properties to lowerTitleCase, but then the settingName in the
SettingStateBinding is not and people spend ages debugging it. Writing
it explicitly makes it clearer. The config file format is unchanged.

M  +2    -2    src/kcms/xwayland/kwinxwaylandsettings.kcfg
M  +25   -0    src/kcms/xwayland/ui/main.qml

https://invent.kde.org/plasma/kwin/-/commit/a4856a015b2a72d1ae9ff53799a7d16b1f6e3022
Comment 3 Vlad Zahorodnii 2024-09-21 13:44:04 UTC 
Git commit 623a1939d21d2e6e57db8dc9afbef38c2e163304 by Vlad Zahorodnii.
Committed on 21/09/2024 at 13:14.
Pushed by vladz into branch 'Plasma/6.2'.

kcms/xwayland: Add settingStateBindings

This adds the orange highlights of which settings are changed within the
KCM.

The KCFG file is modified as QML bindings automatically convert
properties to lowerTitleCase, but then the settingName in the
SettingStateBinding is not and people spend ages debugging it. Writing
it explicitly makes it clearer. The config file format is unchanged.


(cherry picked from commit a4856a015b2a72d1ae9ff53799a7d16b1f6e3022)

Co-authored-by: David Edmundson <kde@davidedmundson.co.uk>

M  +2    -2    src/kcms/xwayland/kwinxwaylandsettings.kcfg
M  +25   -0    src/kcms/xwayland/ui/main.qml

https://invent.kde.org/plasma/kwin/-/commit/623a1939d21d2e6e57db8dc9afbef38c2e163304