Summary: | Fails to build against libjxl 0.9 | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Christoph Reiter <reiter.christoph> |
Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 5.2.2 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Other | ||
Latest Commit: | https://invent.kde.org/graphics/krita/-/commit/021389637e50638b096c7227cf5c06e6444cef89 | Version Fixed In: | |
Sentry Crash Report: |
Description
Christoph Reiter
2023-12-25 08:28:27 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/2040 Git commit ace7edcca6ad322581ab39620f21ccf3ffbd3b5a by Dmitry Kazakov, on behalf of Timo Gurr. Committed on 05/01/2024 at 15:04. Pushed by dkazakov into branch 'master'. Fix build with libjxl 0.9.0 Fix build with libjxl 0.9.0 Test Plan --------- * Upgrade to libjxl 0.9.0 * Apply patch from MR and build krita (5.2.2) * Open/Display a sample image e.g. https://jpegxl.info/test-page/red-room.jxl Formalities Checklist --------------------- - [x] I confirmed this builds. - [x] I confirmed Krita ran and the relevant functions work (Could successfully open/display a sample image https://jpegxl.info/test-page/red-room.jxl). - [ ] I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!) - [x] I made sure my commits build individually and have good descriptions as per [KDE guidelines](https://community.kde.org/Policies/Commit_Policy). - [x] I made sure my code conforms to the standards set in the HACKING file. - [x] I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per [KDE Licensing Policy](https://community.kde.org/Policies/Licensing_Policy). _**Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build.**_ _**If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.**_ M +14 -1 plugins/impex/jxl/JPEGXLImport.cpp https://invent.kde.org/graphics/krita/-/commit/ace7edcca6ad322581ab39620f21ccf3ffbd3b5a Git commit 021389637e50638b096c7227cf5c06e6444cef89 by Dmitry Kazakov, on behalf of Timo Gurr. Committed on 28/01/2024 at 10:13. Pushed by dkazakov into branch 'krita/5.2'. Fix build with libjxl 0.9.0 Fix build with libjxl 0.9.0 Test Plan --------- * Upgrade to libjxl 0.9.0 * Apply patch from MR and build krita (5.2.2) * Open/Display a sample image e.g. https://jpegxl.info/test-page/red-room.jxl Formalities Checklist --------------------- - [x] I confirmed this builds. - [x] I confirmed Krita ran and the relevant functions work (Could successfully open/display a sample image https://jpegxl.info/test-page/red-room.jxl). - [ ] I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!) - [x] I made sure my commits build individually and have good descriptions as per [KDE guidelines](https://community.kde.org/Policies/Commit_Policy). - [x] I made sure my code conforms to the standards set in the HACKING file. - [x] I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per [KDE Licensing Policy](https://community.kde.org/Policies/Licensing_Policy). _**Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build.**_ _**If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.**_ M +14 -1 plugins/impex/jxl/JPEGXLImport.cpp https://invent.kde.org/graphics/krita/-/commit/021389637e50638b096c7227cf5c06e6444cef89 |