| Summary: | SDR Brightness slider affects HDR content | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Jonathan Bennett <jbennett> |
| Component: | compositing | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | calvinatorzcraft |
| Priority: | NOR | Keywords: | qt6 |
| Version First Reported In: | 5.90.0 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/-/commit/4425bcd4e0b98a91c3500afe7204fec22b9032f6 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Jonathan Bennett
2023-12-22 00:29:11 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/4828 Git commit 4425bcd4e0b98a91c3500afe7204fec22b9032f6 by Xaver Hugl. Committed on 22/12/2023 at 13:28. Pushed by zamundaaa into branch 'master'. backends/drm: handle missing brightness values in the EDID better Most importantly, fall back to an assumption of 1000 nits peak brightness when the max brightness is missing, instead of the sdr brightness, which causes more immediately visible issues. Ideally the user should configure this value in the display settings, but it's too late to still do that for Plasma 6.0. M +5 -8 src/backends/drm/drm_output.cpp M +10 -16 src/backends/drm/drm_pipeline.cpp M +4 -4 src/core/output.cpp M +7 -7 src/core/output.h M +24 -5 src/utils/edid.cpp M +13 -10 src/utils/edid.h M +3 -3 src/wayland/outputdevice_v2.cpp https://invent.kde.org/plasma/kwin/-/commit/4425bcd4e0b98a91c3500afe7204fec22b9032f6 (In reply to Zamundaaa from comment #2) > Git commit 4425bcd4e0b98a91c3500afe7204fec22b9032f6 by Xaver Hugl. > Committed on 22/12/2023 at 13:28. > Pushed by zamundaaa into branch 'master'. > > backends/drm: handle missing brightness values in the EDID better > > Most importantly, fall back to an assumption of 1000 nits peak brightness > when the > max brightness is missing, instead of the sdr brightness, which causes more > immediately > visible issues. > Ideally the user should configure this value in the display settings, but > it's too > late to still do that for Plasma 6.0. > > M +5 -8 src/backends/drm/drm_output.cpp > M +10 -16 src/backends/drm/drm_pipeline.cpp > M +4 -4 src/core/output.cpp > M +7 -7 src/core/output.h > M +24 -5 src/utils/edid.cpp > M +13 -10 src/utils/edid.h > M +3 -3 src/wayland/outputdevice_v2.cpp > > https://invent.kde.org/plasma/kwin/-/commit/ > 4425bcd4e0b98a91c3500afe7204fec22b9032f6 Is this functionally equivalent to running "kscreen-doctor output.2.maxBrightnessOverride.1000" ? Managed to recompile Fedora's kwin with this patch, and can confirm it does fix the issue. Thanks! This is happening again on latest kwin (In reply to calvin from comment #5) > This is happening again on latest kwin Scratch that, looks like it's intended on latest kde since it handles tonemapping more heavily now, set it to 203 for a more-or-less accurate look |