| Summary: | overview effect leaks memory | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Harald Sitter <sitter> |
| Component: | effects-overview | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | fanzhuyifan, qufiwefefwoyn |
| Priority: | NOR | Keywords: | qt6 |
| Version First Reported In: | master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=479846 | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/-/commit/228ef989b4264b9cbac029c00d399dfb9f4bd0c2 | Version Fixed/Implemented In: | 6.0 |
| Sentry Crash Report: | |||
|
Description
Harald Sitter
2023-12-20 13:07:56 UTC
The leak seems to happen much more when running a game. Case in point when I have steam open + the game Dorfromantik (+firefox,dolphin,telegram,element,discord,bottles) I get a some 100M leaked every cycle. Some more findings: running a bunch of fullscreen glxgears also seems to help produce the leak. Also, as further confirmation that we are leaking mappings: /proc/pid/maps keeps growing new maps after each overview. Unfortunately due to the amount of mmap calls it's a bit awkward to debug this further. Will probably need some scripting to trace call stacks and then filter out all the ones that were unmapped again :/ A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/4942 Git commit 203c4998bca5a949f05c495040ecce5e4a6d4eeb by David Redondo. Committed on 16/01/2024 at 13:45. Pushed by davidre into branch 'master'. Make sure window thumbnails and Qt Quick resources are destroyed properly Drops the doneCurrent as it was preventing proper cleanUp because no context was current when textures were deleted. Also avoid manipulating the context when Qt has the current one, as various Qt classes have guards around their cleanup handlers which rely on a current Qt context. Despite the comment the order of render control and view destruction needs to be switched as the QQuickWindow destructor calls into the render control to notify if of window destruction. Related: bug 479846 FIXED-IN:6.0 M +1 -2 src/effect/offscreenquickview.cpp M +10 -10 src/scripting/windowthumbnailitem.cpp https://invent.kde.org/plasma/kwin/-/commit/203c4998bca5a949f05c495040ecce5e4a6d4eeb Git commit 228ef989b4264b9cbac029c00d399dfb9f4bd0c2 by Vlad Zahorodnii, on behalf of David Redondo. Committed on 16/01/2024 at 14:34. Pushed by vladz into branch 'Plasma/6.0'. Make sure window thumbnails and Qt Quick resources are destroyed properly Drops the doneCurrent as it was preventing proper cleanUp because no context was current when textures were deleted. Also avoid manipulating the context when Qt has the current one, as various Qt classes have guards around their cleanup handlers which rely on a current Qt context. Despite the comment the order of render control and view destruction needs to be switched as the QQuickWindow destructor calls into the render control to notify if of window destruction. Related: bug 479846 FIXED-IN:6.0 (cherry picked from commit 203c4998bca5a949f05c495040ecce5e4a6d4eeb) M +1 -2 src/effect/offscreenquickview.cpp M +10 -10 src/scripting/windowthumbnailitem.cpp https://invent.kde.org/plasma/kwin/-/commit/228ef989b4264b9cbac029c00d399dfb9f4bd0c2 *** Bug 480100 has been marked as a duplicate of this bug. *** |