Bug 478580

Summary: RDP connection fails with cliprdr error
Product: [Applications] krdc Reporter: Unknown <null>
Component: RDPAssignee: Urs Wolfer <uwolfer>
Status: RESOLVED FIXED    
Severity: normal CC: aacid, ahiemstra, ctrlaltca, nicolas.fella
Priority: NOR Keywords: qt6
Version First Reported In: 24.01.80   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Full log generated by KRDC when run from the terminal
1-minute patch

Description Unknown 2023-12-15 19:57:27 UTC 
SUMMARY
After initiating an RDP connection, the connection is closed with the error dialog: "The connection to the server was closed.".  

When run from the terminal the log shows the true error:
[11:16:12:736] [46282:46540] [ERROR][com.freerdp.channels.cliprdr.client] - context->custom not set!
[11:16:12:736] [46282:46540] [ERROR][com.freerdp.channels.cliprdr.client] - cliprdr_process_general_capability failed with error 1359!
[11:16:12:736] [46282:46540] [ERROR][com.freerdp.channels.cliprdr.client] - cliprdr_process_clip_caps failed with error 1359!
[11:16:12:737] [46282:46540] [ERROR][com.freerdp.channels.cliprdr.client] - cliprdr_order_recv failed with error 1359!
[11:16:12:737] [46282:46544] [ERROR][com.freerdp.core] - cliprdr_virtual_channel_client_thread reported an error. Error was 1359
[11:16:12:737] [46282:46544] [ERROR][com.freerdp.core] - checkChannelErrorEvent() failed - 0

Initiating the same connection from xfreerdp succeeds as expected

STEPS TO REPRODUCE
1.  Choose RDP as connection type
2.  Enter an IP
3.  Click connect button
4.  Leave Host Configuration at defaults
5.  Click OK
6.  Enter username and password at prompt
7.  Click OK
8.  KRDC window turns blue
9.  Error dialog with message "The connection to the server was closed." appears

OBSERVED RESULT
Connection is closed with error dialog

EXPECTED RESULT
Connection succeeds and the remote desktop is displayed

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 6.6.7 / Plasma 6
KDE Plasma Version: 5.90.0
KDE Frameworks Version: 5.246.0
Qt Version: 6.6.1

ADDITIONAL INFORMATION
Comment 1 Unknown 2023-12-15 19:59:45 UTC 
Created attachment 164211 [details]
Full log generated by KRDC when run from the terminal
Comment 2 Fabio 2023-12-25 21:32:41 UTC 
Created attachment 164444 [details]
1-minute patch
Comment 3 Fabio 2023-12-25 21:35:28 UTC 
I'm having the same issue; some investigation lead to this method on the freerdp sample client: https://github.com/FreeRDP/FreeRDP/blob/master/client/Sample/tf_channels.c#L41
I've attached a 1-minute patch that reproduces the same code in krdc; it avoid the error, so now the connection works, but i didn't check if there are any implications.
Comment 4 Nicolas Fella 2024-01-26 14:11:21 UTC 
fixed with https://invent.kde.org/network/krdc/-/merge_requests/63