Bug 478198

Created attachment 163981 [details]
Screenshot showing imported classifiers I and C

Cannot reproduce, see attached screenshot.

Created attachment 164045 [details]
Import of full project (see comment 2) with override keywords.

Created attachment 164046 [details]
Import of full project (see comment 2) without override keywords.

(In reply to Oliver Kellogg from comment #1)
> Created attachment 163981 [details]
> Screenshot showing imported classifiers I and C
> 
> Cannot reproduce, see attached screenshot.
Nor can I... It's weird, I accurately tested the reproducer before opening the bug report and I'm 100% sure it behaved as I wrote in my first post.

Anyway, I can still reproduce garbage behavior with my original header file. You can download it here: 

https://basket.fi.infn.it:443/f/ee0c58a81b/?dl=1)

together with a cpp file for compiling everything and check that it's correct code. Sorry for the poor overall state of the code but it's just a playground for testing ideas, and I was trying to extract the UML with Umbrello after verifying that the overall design works for me.
When importing the test.h header the AlgoSequenceDecorator class is imported without any method, and the AlgoSequence and MTScheduler classes are not imported at all. Removing all the override keywords (sed -i 's/override//g' test.h) the AlgoSequenceDecorator is imported with all its methods, and also AlgoSequence is now imported; however MTScheduler is stil missing, so probably there's more than just override. I uploaded two screenshots showing this behavior.

The code compiles fine both with and without the override keywords, so it's valid and thus I think this is a problem with Umbrello.

Your full header file is helpful indeed, I can now reproduce problems.

Here is the current status of import:

class COUTC : public std::ostream {                                OK
class Configurable /*: public IConfigurable*/ {                    NOT IMPORTED
class IAlgorithm : public Configurable {                           OK
class Algorithm : public IAlgorithm {                              OK
class ConcreteAlgorithm : public Algorithm {                       OK
class AlgoSequenceDecorator;                                       OK
class IAlgoExecutor {                                              OK
class PlainAlgoExecutor : public IAlgoExecutor {                   OK
class AlgoExecutorDecorator : public IAlgoExecutor {               OK
class IAlgoScheduler {                                             OK
class SequentialScheduler : public IAlgoScheduler {                NOT IMPORTED
class MTScheduler : public IAlgoScheduler {                        NOT IMPORTED
class IAlgoSequence : public IAlgorithm {                          OK
class AlgoSequence : public IAlgoSequence {                        NOT IMPORTED
class AlgoSequenceDecorator : public IAlgoSequence {               NOT IMPORTED
class SchedulerDecorator : public IAlgoScheduler {                 OK
class GarbageCollectorDecorator : public AlgoSequenceDecorator {   NOT IMPORTED
  class GarbageCollectorScheduler : public SchedulerDecorator {    NOT IMPORTED
  class GarbageCollectorExecutor : public AlgoExecutorDecorator {  OK

Messages in Log window: 
      
test.h:58:109: error: ';' expected found '}'
test.h:58:110: error: Syntax error before ')'
test.h:59:14: error: ';' expected found 'GetParameter'
test.h:68:0: error: Syntax error before 'private'
test.h:70:0: error: Syntax error before '}'

Those lines are in class Configurable:
58:  template <class T> void SetParameter(std::string name, T val) { _params.push_back({name, typeid(val).name()}); }
59:  std::string GetParameter(std::string name) /* override*/ {

The actual problem is
    _params.push_back({name, typeid(val).name()}); 
where the parser is not handling the ad hoc pair construct
    {name, typeid(val).name()}

Created attachment 164078 [details]
test.h from test.tar at https://basket.fi.infn.it:443/f/ee0c58a81b/?dl=1

Git commit ee83f8db682b8050038034cdd41d15c8f8cbed3c by Oliver Kellogg.
Committed on 10/12/2023 at 21:46.
Pushed by okellogg into branch 'master'.

lib/cppparser/parser.cpp : Address problems uncovered by https://bugs.kde.org/attachment.cgi?id=164078

- In function skip(int l, int r) remove special handling for case
     l != '{' && (tk == '{' || tk == '}' || tk == ';')
- In function skipExpression handle case '{' by skip('{', '}').
- In function parsePtrOperator handle case Token_and (reference
  operator).
- In function parseMemInitializer handle { } in addition to ( ) as
  delimiters for initialization expression.
- In function parseFunctionBody use skip('{', '}') in lieu of detailed
  function body statement representations.
- In function parsePrimaryExpression add case Token_default for
  supporting usages like ~IAlgoScheduler() = default.
FIXED-IN: 2.38.80 (KDE releases 24.01.80)

M  +32   -9    lib/cppparser/parser.cpp

https://invent.kde.org/sdk/umbrello/-/commit/ee83f8db682b8050038034cdd41d15c8f8cbed3c

Thank you very much Oliver.

(In reply to Nicola Mori from comment #8)
> Thank you very much Oliver.

Sure.
Feel free to reopen or open new bug in case of further problems.