Bug 478170

Summary: OverlaySheet listview contents can escape from frame while scrolling
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: Nate Graham <nate>
Component: generalAssignee: kdelibs bugs <kdelibs-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: me, notmart
Priority: NOR Keywords: qt6
Version First Reported In: Master   
Target Milestone: Not decided   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Escapes at the top
Not clipped by the footer

Description Nate Graham 2023-12-06 15:35:33 UTC
Created attachment 163945 [details]
Escapes at the top

Plasma 6 Wayland, git master everything. See attached screenshots from the KWin rules KCM and Digital Clock settings window.
Comment 1 Nate Graham 2023-12-06 15:36:08 UTC
Created attachment 163946 [details]
Not clipped by the footer
Comment 2 ratijas 2023-12-06 17:52:58 UTC
Just set `clip: true` on a ListView. It is probably a fallout from removing clipping from qqc2-d-s ScrollView. Alternatively, can be set a ScrollView in OverlaySheet itself.
Comment 3 Bug Janitor Service 2023-12-07 03:16:42 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kcmutils/-/merge_requests/187
Comment 4 Nate Graham 2023-12-07 17:29:59 UTC
Git commit 97512b7f0b81b48f567ed721c7d2e0e8dc688d73 by Nate Graham.
Committed on 07/12/2023 at 18:29.
Pushed by ngraham into branch 'master'.

applets/digital-clock: clip tomezone popup's list view

Otherwise it escapes!

M  +1    -0    applets/digital-clock/package/contents/ui/configTimeZones.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/97512b7f0b81b48f567ed721c7d2e0e8dc688d73
Comment 5 Nate Graham 2023-12-07 17:31:20 UTC
Git commit d3ece17ddeb6d7957e689e80b3f53678060358ee by Nate Graham.
Committed on 07/12/2023 at 18:30.
Pushed by ngraham into branch 'master'.

kcms/rules: clip rules popup's list view

Otherwise it escapes!

M  +1    -0    src/kcms/rules/ui/RulesEditor.qml

https://invent.kde.org/plasma/kwin/-/commit/d3ece17ddeb6d7957e689e80b3f53678060358ee
Comment 6 Nate Graham 2023-12-07 17:32:18 UTC
If you find this bug report and are tempted to re-open it, please instead submit a new bug report about the specific thing that's overflowing, as each one needs to be fixed individually.
Comment 7 ratijas 2023-12-07 20:37:40 UTC
Git commit 98c18c7e6deafa872f72b005312749421a31b470 by ivan tkachenko.
Committed on 07/12/2023 at 04:16.
Pushed by ratijas into branch 'master'.

ScrollViewKCM: Clip Flickable content whenever there is a header and/or a footer

Fixes appearance after a change to qqc2-desktop-style surfaced this kind
of hidden bugs all over the place:

https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/332

M  +7    -0    src/qml/components/ScrollViewKCM.qml

https://invent.kde.org/frameworks/kcmutils/-/commit/98c18c7e6deafa872f72b005312749421a31b470