| Summary: | Date string of Digital Clock hover window and multi-timezone in main window doesn't follow locale setting like date in panel | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Celeste Liu <uwu> |
| Component: | Digital Clock widget | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jtamate, nate |
| Priority: | NOR | Keywords: | qt6 |
| Version First Reported In: | 5.27.80 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=477723 | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/445521687302fb6f52f8b8aee0dd5383c5f28f81 | Version Fixed/Implemented In: | 6.0 |
| Sentry Crash Report: | |||
| Attachments: |
Hover window
main window |
||
Created attachment 163524 [details]
main window
Addition Information: I patched plasma-workspace with https://invent.kde.org/plasma/plasma-workspace/-/commit/5a32ea2b636c3ef2b4215fafcb78bc17dd93190c manually to make long date format work. Seem this line doesn't pass locale: https://invent.kde.org/plasma/plasma-workspace/-/blob/master/applets/digital-clock/package/contents/ui/Tooltip.qml#L60 Should it be modified like this line? https://invent.kde.org/plasma/plasma-workspace/-/commit/5a32ea2b636c3ef2b4215fafcb78bc17dd93190c#810c09b693009a4d957115b550c48727acbf728d_659_659 Ok, it can fix this problem, I will submit a MR. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3606 Git commit b2116d1f0a28f522c12d11df3077e095afc9cb11 by Fushan Wen, on behalf of Celeste Liu. Committed on 14/02/2024 at 02:26. Pushed by fusionfuture into branch 'master'. applets/digitalclock: make tooltip and multi-timezone follow locale date format https://invent.kde.org/plasma/plasma-workspace/-/commit/5a32ea2b636c3ef2b4215fafcb78bc17dd93190c move Qt.formatDate usage to Qt6 new way, but left code in Tooltip and timezone. This commit pass Qt.locale to Qt.formatDate in tooltip and multi-timezone, make sure them follow locale date format. FIXED-IN: 6.0 Signed-off-by: Celeste Liu <CoelacanthusHex@gmail.com> M +4 -4 applets/digital-clock/package/contents/ui/Tooltip.qml M +1 -1 applets/digital-clock/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/b2116d1f0a28f522c12d11df3077e095afc9cb11 Git commit 445521687302fb6f52f8b8aee0dd5383c5f28f81 by Fushan Wen, on behalf of Celeste Liu. Committed on 14/02/2024 at 02:29. Pushed by fusionfuture into branch 'Plasma/6.0'. applets/digitalclock: make tooltip and multi-timezone follow locale date format https://invent.kde.org/plasma/plasma-workspace/-/commit/5a32ea2b636c3ef2b4215fafcb78bc17dd93190c move Qt.formatDate usage to Qt6 new way, but left code in Tooltip and timezone. This commit pass Qt.locale to Qt.formatDate in tooltip and multi-timezone, make sure them follow locale date format. FIXED-IN: 6.0 Signed-off-by: Celeste Liu <CoelacanthusHex@gmail.com> (cherry picked from commit b2116d1f0a28f522c12d11df3077e095afc9cb11) M +4 -4 applets/digital-clock/package/contents/ui/Tooltip.qml M +1 -1 applets/digital-clock/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/445521687302fb6f52f8b8aee0dd5383c5f28f81 *** Bug 475599 has been marked as a duplicate of this bug. *** |
Created attachment 163523 [details] Hover window STEPS TO REPRODUCE 1. Enable Digital Clock in plasmashell 2. Set the date format to the long date and use a locale with its own date format, such as zh_CN 3. set multi-timezone in digital clock settings 4. See the date string in the panel, hover window, and main window OBSERVED RESULT The date string in the panel and left-top corner of the main window follows the locale setting, use Chinese. But the date string in the hover window and multi-timezone of the main window use English date format. EXPECTED RESULT All of them should follow the locale setting, and use Chinese. SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.27.80 KDE Frameworks Version: 5.245.0 Qt Version: 6.6.0 Kernel Version: 6.6.2-zen1-1-zen (64-bit) Graphics Platform: Wayland Processors: 16 × AMD Ryzen 7 5800H with Radeon Graphics Memory: 27.3 GiB of RAM Graphics Processor: AMD Radeon Graphics Manufacturer: LENOVO Product Name: 82JW System Version: Lenovo Legion R70002021 ADDITIONAL INFORMATION