Bug 477444

Summary:	Pressing `ESC` in the `Set Window Shortcut` dialog should close that dialog
Product:	[Plasma] kwin	Reporter:	Jin Liu <ad.liu.jin>
Component:	general	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED INTENTIONAL
Severity:	minor	CC:	fanzhuyifan
Priority:	NOR	Keywords:	qt6
Version First Reported In:	5.27.80
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Jin Liu 2023-11-24 04:17:17 UTC

Since the user is very unlikely to set `ESC` as the shortcut, it's better that the usual way to close a dialog still works.

STEPS TO REPRODUCE
1. In the window menu, select `set window shortcut`.
2. Press `ESC`.

OBSERVED RESULT
The shortcut is set to `ESC`.

EXPECTED RESULT
The dialog is closed.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.27.80
KDE Frameworks Version: 5.245.0
Qt Version: 6.6.0
Kernel Version: 6.6.2-arch1-1 (64-bit)
Graphics Platform: offscreen
Processors: 12 × AMD Ryzen 5 5600H with Radeon Graphics
Memory: 13.5 GiB of RAM
Graphics Processor: AMD Radeon Graphics

Comment 1 fanzhuyifan 2023-11-24 20:16:25 UTC

Some users actually want to set it to ESC...