| Summary: | Application Dashboard: Can't select items via keyboard after searching | ||
|---|---|---|---|
| Product: | [Plasma] kdeplasma-addons | Reporter: | Jan Rathmann <jan.rathmann> |
| Component: | Application Dashboard | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | 273ex2vl6, alphaLimaTango, andy, hans.tovetjarn, nate, nicolas.fella, polardelphine, rune.fritzsche, samuel.maier2+bugs.kde.org, thepixelbozz, villeneuve, zachisaunders12 |
| Priority: | NOR | Keywords: | qt6 |
| Version: | 6.0.1 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=483142 | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/-/commit/86faa13193b51cc789d0f89d55f6a6ae20ccd984 | Version Fixed In: | 6.0.5 |
| Sentry Crash Report: | |||
| Attachments: | Workaround that makes launching apps via Enter key work again | ||
|
Description
Jan Rathmann
2023-11-21 21:57:58 UTC
Created attachment 165564 [details]
Workaround that makes launching apps via Enter key work again
Was debugging this for some hours during the last weeks, but still it isn't clear to me was exactly causes this bug or what would work to fix it. It seems it might be related to some change between Qt5 and Qt6, or some change to applets behaviour between P5 and P6. I would need a lot more experience in QML and Plasma applet development to make any progress on this, I guess.
Anyway, I found a workaround to make at least launching apps via Enter key work again. I have attached the respecting patch, but I'm really unsure if this is the way it should be implemented (that's why I didn't make a merge request).
Thanks for the patch Jan. I can confirm it works on my system (arch linux, plasma 6.0.1). IMO if it works it works and might as well submit it for some progress. Additional observations (without the patch): - hovering over an icon in Favorites or Applications, a square border appears around the hovered icon, and pressing Enter opens the item. - after typing something in search, the first item in the result should have the square border but it does not - hovering over one of the items in the search result does show a square border, but pressing Enter opens a different item I have the same Issue. I cannot select any items via the keyboard and also when wanting to search for application in application dashboard I have to first manually click into the search field then type. Also when hitting enter after typing a keywoard (which previously opened the respective application) now just does not work anymore at all. Note that the aspect of what happens if you press enter is or was handled in other issues, this issues remains with a strict focus on selecting an item with arrow down and tab. I will also be so free and adjust the plasma version. While the original issue was observed in plasma 5, and just concerned the plasma 6 version of the applet, this has been observed multiple times in plasma 6 now. The solution to the issue of opening an application with enter (https://bugs.kde.org/show_bug.cgi?id=483142) should probably be tested with a fix for this issue, so I'd recommend handling this first. It seems I need to submit changes to the plasma version with a comment... I'm on plasmashell 6.0.3 and can confirm this bug too Git commit 9817d455fcfb1897f74dfdbcdf3de50e9fd66d77 by Marco Martin. Committed on 16/04/2024 at 08:01. Pushed by mart into branch 'master'. Fix keyboard navigation As a fallout from porting to kf6, there were sevaral items that were renamed and not all users now accessed the proper id this fixes keyboard navigation in krunner results and "all applications" view Related: bug 485588 M +2 -0 applets/kicker/package/contents/ui/DashboardRepresentation.qml M +37 -37 applets/kicker/package/contents/ui/ItemMultiGridView.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/9817d455fcfb1897f74dfdbcdf3de50e9fd66d77 Git commit 86faa13193b51cc789d0f89d55f6a6ae20ccd984 by Marco Martin. Committed on 16/04/2024 at 12:12. Pushed by mart into branch 'Plasma/6.0'. Fix keyboard navigation As a fallout from porting to kf6, there were sevaral items that were renamed and not all users now accessed the proper id this fixes keyboard navigation in krunner results and "all applications" view Related: bug 485588 (cherry picked from commit 9817d455fcfb1897f74dfdbcdf3de50e9fd66d77) f290bb9e Fix keyboard navigation M +2 -0 applets/kicker/package/contents/ui/DashboardRepresentation.qml M +37 -37 applets/kicker/package/contents/ui/ItemMultiGridView.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/86faa13193b51cc789d0f89d55f6a6ae20ccd984 This is sadly not fixed. The keyboard navigation does not work after searching, only after just opening the application dashboard. (In reply to Rune from comment #9) > This is sadly not fixed. The keyboard navigation does not work after > searching, only after just opening the application dashboard. Strange, the keyboard navigation does still work for me after typing search text. (I run a kdesrc-build from git master.) It was my mistake; the commit that fixed this went in right after 6.0.4 was tagged, so it'll be in 6.0.5 instead. |