Bug 477324

Summary:	Apply button does not activate when changing the number in the "Lock screen automatically" spinbox until focusing away
Product:	[Applications] systemsettings	Reporter:	postix <postix>
Component:	kcm_screenlocker	Assignee:	Tom <bad63r>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bad63r, bugseforuns, florian.richer, nate
Priority:	NOR	Keywords:	junior-jobs
Version:	5.27.9
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/kscreenlocker/-/commit/311db2a9c45c1b3289addb25f3da15f34db818fe	Version Fixed In:	6.1
Sentry Crash Report:

Description postix 2023-11-21 12:16:10 UTC

STEPS TO REPRODUCE
1. Go to the lockscreen kcm
2. Have "lock screen automatically" already enabled
3. Click into the spinbox and change the number

OBSERVED RESULT
Apply button stays disabled. When switching the kcm the user is asked to confirm the change.

EXPECTED RESULT
Apply button becomes enabled.


SOFTWARE/OS VERSIONS
Windows: 
Operating System: Fedora Linux 39
KDE Plasma Version: 5.27.9
KDE Frameworks Version: 5.111.0
Qt Version: 5.15.11

Comment 1 Nate Graham 2023-11-30 21:51:29 UTC

The actual change isn't noticed until focus moves elsewhere, at which point the Apply button becomes active. We can improve this.

Comment 2 Tom 2023-12-18 15:13:14 UTC

I can reproduce this as well.

SOFTWARE/OS VERSIONS
Operating System: Kubuntu 22.04
KDE Plasma Version: 5.27.10
KDE Frameworks Version: 5.104.0
Qt Version: 5.15.3

I will try to fix it. Should I "take" assignee info on myself? I'm not sure how this should be correctly taken

Tom

Comment 3 Nate Graham 2024-01-17 23:15:29 UTC

Go ahead. You never need to ask permission in KDE to start working on something. :)

Comment 4 Nate Graham 2024-01-19 18:50:21 UTC

Will be fixed by https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/175.

Comment 5 Nate Graham 2024-02-13 18:26:15 UTC

Git commit 311db2a9c45c1b3289addb25f3da15f34db818fe by Nate Graham, on behalf of Kristen McWilliam.
Committed on 13/02/2024 at 18:26.
Pushed by ngraham into branch 'master'.

KCM: make delay unit not editable and overhaul delay-setting UI

Currently the user can select and edit the delay units in the config,
leading them to believe that they can change "minutes" to "seconds"
or "hours". This is not the case, and causes confusion.

See this Reddit thread for reference of the confusion:
https://old.reddit.com/r/kde/comments/tpvp5h/why_such_an_arbitrary_number_for_allow_unlocking/

This change makes them ComboBox components instead, with an optional
"Custom" entry for the user to specify any time desired.
FIXED-IN: 6.1

A  +142  -0    kcm/ui/DurationPromptDialog.qml     [License: GPL(v2.0+)]
M  +300  -30   kcm/ui/main.qml
M  +1    -4    settings/kscreenlockersettings.kcfg

https://invent.kde.org/plasma/kscreenlocker/-/commit/311db2a9c45c1b3289addb25f3da15f34db818fe