| Summary: | Crash after pressing both mouse buttons | ||
|---|---|---|---|
| Product: | [Applications] kate | Reporter: | Grósz Dániel <groszdanielpub> |
| Component: | general | Assignee: | KWrite Developers <kwrite-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | christoph |
| Priority: | NOR | Keywords: | drkonqi |
| Version First Reported In: | 23.08.1 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/utilities/kate/-/commit/02d8b49b0995ce616f9a7ffbedda7e7fecb8c5eb | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Grósz Dániel
2023-11-19 10:07:45 UTC
Hmmm, instead of that self managing, can we not just add these actions to the xmlgui file like the ctags plugin does it?
<Menu name="ktexteditor_popup" noMerge="1">
<Action name="popup_ctags"/>
</Menu>
We can even add some merge area if we need that.
(In reply to Christoph Cullmann from comment #1) > Hmmm, instead of that self managing, can we not just add these actions to > the xmlgui file like the ctags plugin does it? > > <Menu name="ktexteditor_popup" noMerge="1"> > <Action name="popup_ctags"/> > </Menu> > > We can even add some merge area if we need that. Did you mean to post this under this bug? Yes, as comment how we might fix the stuff in LSPClientPluginViewImpl::prepareContextMenu that seems to crash below. (In reply to Christoph Cullmann from comment #3) > Yes, as comment how we might fix the stuff in > LSPClientPluginViewImpl::prepareContextMenu that seems to crash below. Ah, OK. A possibly relevant merge request was started @ https://invent.kde.org/utilities/kate/-/merge_requests/1371 Git commit 02d8b49b0995ce616f9a7ffbedda7e7fecb8c5eb by Christoph Cullmann. Committed on 14/03/2024 at 17:12. Pushed by cullmann into branch 'master'. move lsp context menu actions to xmlgui avoids crashes M +9 -62 addons/lspclient/lspclientpluginview.cpp M +11 -1 addons/lspclient/ui.rc https://invent.kde.org/utilities/kate/-/commit/02d8b49b0995ce616f9a7ffbedda7e7fecb8c5eb |