| Summary: | Changing the screen dimensions while an effect is open causes the effect to go black | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Devin Lin <espidev> |
| Component: | general | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | nate, xaver.hugl |
| Priority: | NOR | Keywords: | qt6 |
| Version First Reported In: | master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kwin/-/commit/6a997b41ae9acccaba8169eb69c354774085fd00 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Devin Lin
2023-11-15 05:13:37 UTC
Can confirm. The log spams
> kwin_scene_opengl: 0x3: GL_INVALID_OPERATION in glBindBuffer(non-gen name)
on every rendered frame, so presumably something's wrong with the code blitting the effect results to the screen
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/4681 Git commit 6a997b41ae9acccaba8169eb69c354774085fd00 by Vlad Zahorodnii. Committed on 21/11/2023 at 20:11. Pushed by vladz into branch 'master'. Fix screen becoming black when its geometry changes while overview is active Offscreen quick views are repainted in the pre paint step because that requires a QOpenGLContext and we don't want it to mess with kwin's opengl context. After a view is updated, its QOpenGLContext is going to be unbound. During normal operation mode, it works as expected: - the view gets updated in the pre paint stage - kwin opengl context is made current when starting the paint stage - the offscreen view is painted on the screen However, effects->renderScreen() has no such separation. The OpenGL context changes from the pre paint stage will leak to the paint stage. So we have - the workspace notifies that the screens have changed - the screen transform effect sees that, makes opengl context current and renders the screen - the offscreen quick view is updated and after OffscreenQuickView is done, it's going to call QOpenGLContext::doneCurrent() - effects->renderScreen() calls m_scene->paint() - since there's no current opengl context, vbo allocation in GLTexture::render() will fail and nothing will be rendered on the screen As a way around it, this change adds a makeOpenGLContextCurrent() call before the paint stage. It doesn't quite belong there, the opengl context has to be made current in the paint stage, e.g. by the ItemRenderer or something. But atm we have no good place where we could stick it in. M +5 -1 src/effect/effecthandler.cpp https://invent.kde.org/plasma/kwin/-/commit/6a997b41ae9acccaba8169eb69c354774085fd00 |