| Summary: | Specific color selector sets foreground color to black when switching to HSL/HSI/HSY and does not set to correct mode when restarting Krita. | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Lucifer <summonlucifer> |
| Component: | Color Selectors | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 5.2.1 | ||
| Target Milestone: | --- | ||
| Platform: | Mint (Ubuntu based) | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/-/commit/84eccce4ae75329cfd999a08bbe8e22471559ab2 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | This image shows foreground color and the selector is not synced. | ||
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1992 Git commit cd4ca2386730eca514b8525d5c08fd0f4b44d9ec by Dmitry Kazakov, on behalf of Freya Lupen. Committed on 07/11/2023 at 09:26. Pushed by dkazakov into branch 'master'. Fix Specific Color Selector changing to black Its color wasn't initialized, so it showed black. Switching HSX mode would set the view's foreground color to this black. Whether RGB or HSX was checked wasn't being saved, either. M +2 -0 plugins/dockers/specificcolorselector/kis_specific_color_selector_widget.cc M +1 -0 plugins/dockers/specificcolorselector/specificcolorselector_dock.cc https://invent.kde.org/graphics/krita/-/commit/cd4ca2386730eca514b8525d5c08fd0f4b44d9ec Git commit 84eccce4ae75329cfd999a08bbe8e22471559ab2 by Dmitry Kazakov, on behalf of Freya Lupen. Committed on 07/11/2023 at 09:26. Pushed by dkazakov into branch 'krita/5.2'. Fix Specific Color Selector changing to black Its color wasn't initialized, so it showed black. Switching HSX mode would set the view's foreground color to this black. Whether RGB or HSX was checked wasn't being saved, either. (cherry picked from commit cd4ca2386730eca514b8525d5c08fd0f4b44d9ec) M +2 -0 plugins/dockers/specificcolorselector/kis_specific_color_selector_widget.cc M +1 -0 plugins/dockers/specificcolorselector/specificcolorselector_dock.cc https://invent.kde.org/graphics/krita/-/commit/84eccce4ae75329cfd999a08bbe8e22471559ab2 |
Created attachment 162895 [details] This image shows foreground color and the selector is not synced. SUMMARY *** Specific color selector sets foreground color to black when switching to HSL/HSI/HSY and does not set to correct mode when restarting Krita. *** STEPS TO REPRODUCE 1. Make sure the specific color selector is in HSV mode 2. Set foreground color to anything other than black and restart Krita 3. Open any RGB document to load the specific color selector docker 4. Click on the HSV dropdown and select HSL/HSI/HSY 5. Set foreground color to anything other than black and restart Krita again 6. Open any RGB document OBSERVED RESULT On the 3rd step when the specific color selector is loaded, the selector sliders is in rgb mode with all 3 values at 0 despite the foreground color of the active view being of a different color. On the 4th step when selecting HSL/HSI/HSY, regardless of whether their radio button is selected or not, the foreground color of the active view will change to black. On the 6th step after restarting Krita and opening any RGB document, the foreground color will be set to black again. Moreover, the specific color selector has been reset to rgb mode instead of the previously set HSL/HSI/HSY. EXPECTED RESULT On the 3rd step, specific color selector values should be in line with the values of the foreground color. On the 4th step, the specific color selector should not be setting the foreground color based on its current slider values when switching to HSL/HSI/HSY. On the 6th step, the specific color should not reset back to rgb mode and should not be setting the foreground value to its own like on the 4th step as it tries to switch to HSL/HSI/HSY when restarting the application. SOFTWARE/OS VERSIONS Linux/KDE Plasma: Mint 21.2 Cinnamon (available in About System) Krita Versions: 5.2.1 appimage and 5.2.0 appimage ADDITIONAL INFORMATION This is my first time posting a bug report here, so do let me know if I'm missing critical information.