Summary: | Clipboard is sent to phone when reconnecting after disabling clipboard autoshare | ||
---|---|---|---|
Product: | [Applications] kdeconnect | Reporter: | Ditzy <ditzy_dreamland757> |
Component: | common | Assignee: | Albert Vaca Cintora <albertvaka> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | andrew.g.r.holmes, i474yamy |
Priority: | NOR | ||
Version: | 23.08.2 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/network/kdeconnect-kde/-/commit/642c99056837053d943aa04ebd6a487c25d2bd56 | Version Fixed In: |
Description
Ditzy
2023-11-04 15:25:21 UTC
On the connection event, the current contents are unconditionally sent to the device: https://github.com/KDE/kdeconnect-kde/blob/69d6c172142dbec0db4251ecb0aa0ecc2d194193/plugins/clipboard/clipboardplugin.cpp#L74 On the changed event (post-connection), the autoshare and password preferences are checked before the contents are sent: https://github.com/KDE/kdeconnect-kde/blob/69d6c172142dbec0db4251ecb0aa0ecc2d194193/plugins/clipboard/clipboardplugin.cpp#L34 A possibly relevant merge request was started @ https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/660 A possibly relevant merge request was started @ https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/660 A possibly relevant merge request was started @ https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/661 A possibly relevant merge request was started @ https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/661 A possibly relevant merge request was started @ https://invent.kde.org/network/kdeconnect-android/-/merge_requests/419 A possibly relevant merge request was started @ https://invent.kde.org/network/kdeconnect-android/-/merge_requests/419 Git commit 642c99056837053d943aa04ebd6a487c25d2bd56 by Albert Vaca Cintora, on behalf of Marx Zhu. Committed on 31/03/2024 at 14:48. Pushed by albertvaka into branch 'master'. fix: do not send NetworkPacket if autoshare is disabled when connecting M +8 -1 plugins/clipboard/clipboardplugin.cpp https://invent.kde.org/network/kdeconnect-kde/-/commit/642c99056837053d943aa04ebd6a487c25d2bd56 |