| Summary: | Spacebar doesn't always pause/play anymore | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jackhill3103, jf.mundox, justin, putr4.s |
| Priority: | NOR | Keywords: | qt6, regression, usability |
| Version First Reported In: | 22.11.80 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/multimedia/elisa/-/commit/5b191f11f1bae3a2bc6bef988a80d3630ac411c5 | Version Fixed/Implemented In: | 25.04.0 |
| Sentry Crash Report: | |||
|
Description
Nate Graham
2023-11-04 02:27:50 UTC
Don't you want space bar to be able to activate buttons for accessibility? I just tried using enter in System Settings to activate buttons but only the space bar does. In general yes, but in a music player the spacebar usually has a special meaning and toggles play and pause irrespective of focus. That conflicts with the accessibility feature, so we made the decision early in Elisa's development to be consistent with what people except for music players, not what people expect for accessibility. For me this specifically happens for buttons on the player control bar. Except the Show Playlist button which works just fine A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/673 Git commit 5b191f11f1bae3a2bc6bef988a80d3630ac411c5 by Jack Hill. Committed on 01/03/2025 at 16:55. Pushed by jackh into branch 'master'. Fix the spacebar play/pause action when specific buttons have focus An event filter was applied to some specific buttons with the intention of overriding the space-bar for the play/pause action, but actually it had the effect of making the space-bar do nothing when pressed while one of these buttons had focus. The space-bar shortcut is already handled by the Kirigami.Action in ElisaMainWindow, making this event filter unnecessary anyway. M +0 -24 src/elisaapplication.cpp M +0 -4 src/elisaapplication.h M +0 -15 src/qml/MediaPlayerControl.qml https://invent.kde.org/multimedia/elisa/-/commit/5b191f11f1bae3a2bc6bef988a80d3630ac411c5 |