| Summary: | Inconsistent undo and redo after flattening a layer | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | paleh <paleh21669> |
| Component: | Animation | Assignee: | Dmitry Kazakov <dimula73> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dimula73 |
| Priority: | NOR | ||
| Version: | 5.2.1 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/-/commit/7eb718c2543ab120487e1916c6f8d01157ca02f3 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | screen recording of the bug on 5.2.1-f819e29 | ||
|
Description
paleh
2023-11-03 15:29:06 UTC
Hi, paleh! Thank you for the report! The bug seems to be fixed by the patch I pushed in the morning! Please try this build: https://binary-factory.kde.org/job/Krita_Stable_Windows_Build/2034/ *** This bug has been marked as a duplicate of bug 476495 *** Hi, Dmitry Err, which build is it? I can reproduce the bug on 5.2.1-8a2e4c8b0e which you pushed today (at 12:01pm CET) in response to my other bug report. Well, that is the same build. I'll recheck then Hi, paleh! I have restarted the build. Could you try this one when it is ready? https://binary-factory.kde.org/job/Krita_Stable_Windows_Build/2035/ It might be related to the race condition I fixed for another report of yours :) Created attachment 162846 [details]
screen recording of the bug on 5.2.1-f819e29
No, nothing changed with the stable windows build #2035. I recorded a video to demonstrate it. Since it was only a Windows build that you restarted, and because I don't currently have a windows VM, I tested it in Wine, but the result is the same is the same for the stable appimage build #2040.
Thanks for your comment! Automatically switching the status of this bug to REPORTED so that the KDE team knows that the bug is ready to get confirmed. In the future you may also do this yourself when providing needed information. Hi, paleh! Thank you for the video! I can reproduce the issue now! :) Git commit 5537f00ef0973e2887eee31143ec3aa67e3b7e19 by Dmitry Kazakov. Committed on 05/11/2023 at 14:08. Pushed by dkazakov into branch 'master'. Fix redo of a flatten layer operation when it is animated KisKeyFrameChannel already wraps the command into SkipFirstRedoWrapper, so there is no need for another one. This is a regression from 933c1fa041d97a23701e709eec8a9417f9a26fec M +3 -3 libs/image/kis_layer_utils.cpp https://invent.kde.org/graphics/krita/-/commit/5537f00ef0973e2887eee31143ec3aa67e3b7e19 Git commit 7eb718c2543ab120487e1916c6f8d01157ca02f3 by Dmitry Kazakov. Committed on 05/11/2023 at 14:09. Pushed by dkazakov into branch 'krita/5.2'. Fix redo of a flatten layer operation when it is animated KisKeyFrameChannel already wraps the command into SkipFirstRedoWrapper, so there is no need for another one. This is a regression from 933c1fa041d97a23701e709eec8a9417f9a26fec M +3 -3 libs/image/kis_layer_utils.cpp https://invent.kde.org/graphics/krita/-/commit/7eb718c2543ab120487e1916c6f8d01157ca02f3 |