Bug 476454

Summary: Attempting to undo after changing animation layers sometimes results in crash
Product: [Applications] krita Reporter: Alex <alexsmudgy20>
Component: * UnknownAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED WORKSFORME    
Severity: crash CC: dimula73
Priority: NOR    
Version First Reported In: 5.1.5   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Alex 2023-11-02 03:55:59 UTC 
SUMMARY
When using the "Animation" workspace, if you make a change in your document (e.g. drawing a line), change layer, and then undo once or several times, occasionally the program crashes.

STEPS TO REPRODUCE
1. Use the "Animation" workspace
2. Draw lines or perform some action on the canvas
3. Change the current layer
4. Perform the Undo action.

I AM NOT ENTIRELY CERTAIN THE CONDITIONS WHICH THIS ERROR OCCURS IN. I cannot get it to reproduce consistently. You may have more luck if you switch the positions of step 2 and 3. You may need to perform further testing to reproduce this crash and find its conditions.

OBSERVED RESULT
The program immediately closes and all of your unsaved documents are lost.

EXPECTED RESULT
The program should not crash.

Krita

 Version: 5.1.5
 Installation type: installer / portable package
 Hidpi: true

Qt

  Version (compiled): 5.12.12
  Version (loaded): 5.12.12

OS Information

  Build ABI: x86_64-little_endian-llp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: winnt
  Kernel Version: 10.0.19045
  Pretty Productname: Windows 10 (10.0)
  Product Type: windows
  Product Version: 10

Crash Log:

Error occurred on Thursday, November 2, 2023 at 14:41:57.

krita.exe caused an Access Violation at location 00007FFEFEF5FA1C in module libkritaimage.dll Writing to location 00000000000000A0.

AddrPC           Params
00007FFEFEF5FA1C 000002B92C0D3DC0 00007FFF0082D47D 000002B92BDF8EB0  libkritaimage.dll!KisPaintDeviceFramesInterface::setFrameOffset+0x8c
00007FFEFEF95EF8 000002B92BFBAA30 00007FFEFAEEE001 00007FFEFF12F368  libkritaimage.dll!KisTransactionData::undo+0x128
00007FFF3C9F9D17 000002B900000000 000002B9274B9100 000000002710AA00  libkritacommand.dll!KisCommandUtils::CompositeCommand::undo+0xd7
00007FFF3C9F2E70 0000000000000000 0000000100000000 0000000000000000  libkritacommand.dll!KUndo2Command::undo+0x30
00007FFEFED1FE4E 00007FFEFAEEE0A0 000000BFAB2FFD88 0000000000000000  libkritaimage.dll!KisUpdateCommand::undo+0xe
00007FFEFEE668C4 000002B92C5270C0 00007FFF00000000 0000000100000007  libkritaimage.dll!KisStrokeStrategyUndoCommandBased::doStrokeCallback+0xb4
00007FFEFEC7E102 000002B92BDCE8B0 000002B900000000 0000000000000000  libkritaimage.dll!KisUpdateJobItem::run+0x132
00007FFEFAEEFFAD 0000000000000000 0000000000000000 0000000000000000  Qt5Core.dll!QThreadPoolThread::run+0xad
Comment 1 Dmitry Kazakov 2023-11-03 15:14:13 UTC 
Hi, Alex!

Could you please check the latest Krita 5.2.1 if the problem is still present there. I have fixed a lot of animation-related issues in it.
Comment 2 Bug Janitor Service 2023-11-18 03:45:47 UTC 
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Bug Janitor Service 2023-12-03 03:45:50 UTC 
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!