Bug 476336

Summary:	songs not saved to favorites
Product:	[Applications] Elisa	Reporter:	contact
Component:	general	Assignee:	Matthieu Gallien <matthieu_gallien>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate
Priority:	NOR
Version First Reported In:	23.08.2
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/multimedia/elisa/-/commit/2b93beb48d6d1ba32f6a8a189092e5e09bc39e33	Version Fixed/Implemented In:	24.02
Sentry Crash Report:

Description contact 2023-10-30 19:21:58 UTC

SUMMARY
When I set "Song rating style" to "Favorite/not favorite" and I click the star icon on a song it does not get saved as soon as I cluck another song and go back the star icon is not filled in anymore. I'm doing this on the "Recently Play" panel, but it happens when I try to elsewhere too. When I use "0-5 stars" it seems to save correctly.

STEPS TO REPRODUCE
1. Select the hamburger menu
2. Select "Configure Elisa..."
3. Select "Favorite/not favorite", apply, and close the configure window
4. Click the star on a song in the "Recently Played" list
5. Click "Only Show Favorites"

OBSERVED RESULT
song is not in favorites

EXPECTED RESULT
song is saved to favorites

SOFTWARE/OS VERSIONS
Linux: Pop! OS 22.04

ADDITIONAL INFORMATION
I searched and found other bug reports related to saving favorites, but they were not for songs in Elisa.

Comment 1 Nate Graham 2023-11-01 19:23:15 UTC

Thanks for reporting! This is fixed already in Elisa 24.02, most likely by https://invent.kde.org/multimedia/elisa/-/commit/2b93beb48d6d1ba32f6a8a189092e5e09bc39e33, but if not that, then one of the other commits to refactor rating handling.

Comment 2 contact 2024-11-27 21:31:11 UTC

(In reply to Nate Graham from comment #1)
> Thanks for reporting! This is fixed already in Elisa 24.02, most likely by
> https://invent.kde.org/multimedia/elisa/-/commit/
> 2b93beb48d6d1ba32f6a8a189092e5e09bc39e33, but if not that, then one of the
> other commits to refactor rating handling.

I'm using Elisa 24.08.3 now, and I'm still getting this bug. The bug never went away. I've tried adding songs to favorites on multiple menus within Elisa and nothing persists. I click the star and it becomes a filled in star, but when I click "Only Show Favorites" nothing is listed. Also when I leave the menu and come back the star for the song is reset to not being filled in.