Bug 476331

Summary: clean up generated/distributed filter scripts
Product: [Developer tools] valgrind Reporter: Mark Wielaard <mark>
Component: generalAssignee: Julian Seward <jseward>
Status: RESOLVED FIXED    
Severity: normal CC: pjfloyd
Priority: NOR    
Version First Reported In: 3.22 GIT   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Mark Wielaard 2023-10-30 17:28:30 UTC 
https://sourceforge.net/p/valgrind/mailman/message/49958270/

There are a couple of filter scripts generated for configure.ac but also included in the dist tar ball.

drd/tests/filter_error_count
drd/tests/filter_error_summary
drd/tests/filter_stderr
lter_stderr_and_thread_no_and_offset
drd/tests/filter_thread_no
drd/tests/filter_xml_and_thread_no
gdbserver_tests/filter_gdb
filter_memcheck_monitor
gdbserver_tests/filter_stderr
gdbserver_tests/filter_vgdb
helgrind/tests/filter_stderr
memcheck/tests/filter_dw4
memcheck/tests/filter_overlaperror
memcheck/tests/filter_stderr
memcheck/tests/x86/filter_pushfpopf
tests/filter_discards
tests/filter_stderr_basic

All those filter scripts generated by configure.ac by AC_CONFIG_FILES from the .in files should not be in dist_noinst_SCRIPTS but in noinst_SCRIPTS.

When doing this also update the tests/check_headers_and_includes script which is run at the end of make regtest and will check the scripts are listed correctly in the Makefile.am files:

$ make post-regtest-checks
...checking makefile consistency
memcheck/tests/Makefile.am:1: error: filter_dw4 is missing in dist_noinst_SCRIPTS
Comment 1 Paul Floyd 2024-02-02 21:28:55 UTC 
Should be done with these two commits

commit de2cd7f6f9ad06fbe390d37503557718ec15fab4 (HEAD -> master, origin/master, origin/HEAD)
Author: Paul Floyd <pjfloyd@wanadoo.fr>
Date:   Fri Feb 2 22:27:25 2024 +0100

    Bug 476331 - clean up generated/distributed filter scripts

commit 3c9a71a42d9dd28b9315ae937033e53b8a3b9ba4
Author: Paul Floyd <pjfloyd@wanadoo.fr>
Date:   Fri Feb 2 21:17:49 2024 +0100

    Makefiles: bug 476331 cleanup
    
    Quick test with one script to see if buildbot is happy.
Comment 2 Paul Floyd 2024-02-03 14:21:45 UTC 
Didn't see any fallout.