| Summary: | after install 2261 my animation slice up on 5.3 | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | lizard_olmighty <harrynft> |
| Component: | Animation | Assignee: | Dmitry Kazakov <dimula73> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dimula73 |
| Priority: | NOR | Keywords: | regression, release_blocker |
| Version: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/-/commit/7f3152798a08615d41e4e7cd6e0390b6cc67c0e1 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
lizard_olmighty
2023-10-30 08:34:39 UTC
That is the same report as on KA: https://krita-artists.org/t/need-testing-animated-transformation-masks-rewritten/76229/13 I can confirm the issue using the test file that was sent by the reporter to my private email. Git commit b24a3488cf23baa6ad0e41b8aef76cdf0787af87 by Dmitry Kazakov. Committed on 06/11/2023 at 14:23. Pushed by dkazakov into branch 'master'. Fix an offset when opening files with animated transform masks Our curves should be centered againt the rotation center. The current implementation still has a bug that the curve value is **not** the position of the rotation center, but (position - rotationCenterOffset), which is a completely nonsensial value. But since it is baked into .kra format, we should keep it this way for now. M +43 -2 plugins/tools/tool_transform2/KisAnimatedTransformMaskParamsHolder.cpp https://invent.kde.org/graphics/krita/-/commit/b24a3488cf23baa6ad0e41b8aef76cdf0787af87 Just for the sake of completeness, this package should fix the issue: https://binary-factory.kde.org/job/Krita_Nightly_Windows_Build/2273/ Git commit 7f3152798a08615d41e4e7cd6e0390b6cc67c0e1 by Dmitry Kazakov. Committed on 28/02/2024 at 12:49. Pushed by dkazakov into branch 'kazakov/for-5.2'. Fix an offset when opening files with animated transform masks Our curves should be centered againt the rotation center. The current implementation still has a bug that the curve value is **not** the position of the rotation center, but (position - rotationCenterOffset), which is a completely nonsensial value. But since it is baked into .kra format, we should keep it this way for now. M +43 -2 plugins/tools/tool_transform2/KisAnimatedTransformMaskParamsHolder.cpp https://invent.kde.org/graphics/krita/-/commit/7f3152798a08615d41e4e7cd6e0390b6cc67c0e1 |