| Summary: | Header bar says "0 items" while viewing plasma/app addons | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Patrick Silva <bugseforuns> |
| Component: | KNewStuff Backend | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aleixpol, leinir, nate |
| Priority: | NOR | Keywords: | qt6 |
| Version First Reported In: | master | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/discover/-/commit/da234287041afdeaa68205a978385472267705ec | Version Fixed In: | 5.27.10 |
| Sentry Crash Report: | |||
| Attachments: | screenshot | ||
Can reproduce. A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/686 A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/687 A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/698 Git commit 576e460ade383da789727066929d14baa248aa02 by ivan tkachenko. Committed on 24/11/2023 at 18:25. Pushed by ratijas into branch 'master'. Refactor roughCount into an atomic QGadget, fix usage of i18np i18np's first argument should be a valid number. Meanwhile roughCount was a string. Instead we should pass the original number as the plural-deciding argument, while using the formatted string only for the actual substitution. It is only natural to factor out the counter into a gadget class of its own, since all of its properties (and their semantics like the `roughCount.length > 0` special case) change atomically and thus do not require separate connections. Also, let's store the Timer inline, instead of allocating dynamically. M +1 -0 discover/DiscoverDeclarativePlugin.cpp M +7 -8 discover/qml/ApplicationsListPage.qml M +34 -13 libdiscover/resources/ResourcesProxyModel.cpp M +27 -4 libdiscover/resources/ResourcesProxyModel.h https://invent.kde.org/plasma/discover/-/commit/576e460ade383da789727066929d14baa248aa02 Git commit da234287041afdeaa68205a978385472267705ec by ivan tkachenko. Committed on 24/11/2023 at 18:25. Pushed by ratijas into branch 'Plasma/5.27'. Refactor roughCount into an atomic QGadget, fix usage of i18np i18np's first argument should be a valid number. Meanwhile roughCount was a string. Instead we should pass the original number as the plural-deciding argument, while using the formatted string only for the actual substitution. It is only natural to factor out the counter into a gadget class of its own, since all of its properties (and their semantics like the `roughCount.length > 0` special case) change atomically and thus do not require separate connections. Also, let's store the Timer inline, instead of allocating dynamically. (cherry picked from commit 576e460ade383da789727066929d14baa248aa02) (and adapted to Qt 5) M +1 -0 discover/DiscoverDeclarativePlugin.cpp M +8 -9 discover/qml/ApplicationsListPage.qml M +34 -13 libdiscover/resources/ResourcesProxyModel.cpp M +29 -4 libdiscover/resources/ResourcesProxyModel.h https://invent.kde.org/plasma/discover/-/commit/da234287041afdeaa68205a978385472267705ec |
Created attachment 162589 [details] screenshot STEPS TO REPRODUCE 1. open Discover 2. click on Application addons" or "Plasma addons" in the sidebar 3. OBSERVED RESULT the header bar says "0 items". Please see the attached screenshot. EXPECTED RESULT correct number of addons SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.27.80 KDE Frameworks Version: 5.240.0 Qt Version: 6.6.0 Graphics Platform: Wayland