Bug 476054

Summary:	Always set the "nofail" flag for manually created mountpoints?
Product:	[Applications] partitionmanager	Reporter:	Henning <boredsquirrel>
Component:	general	Assignee:	Andrius Štikonas <andrius>
Status:	RESOLVED FIXED
Severity:	minor	CC:	nate, tbertels
Priority:	NOR
Version:	23.08.2
Target Milestone:	---
Platform:	unspecified
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=438672
Latest Commit:	https://invent.kde.org/system/partitionmanager/-/commit/4232098e33115aad1e1174e87661214dffec6adb	Version Fixed In:	24.05
Sentry Crash Report:

Description Henning 2023-10-24 15:25:28 UTC

I had my PC not booting anymore because of a mount in fstab that ddidnt exist anymore.

If it wouldve had the nofail flag, booting would still work.

I think it has no disadvantages to set the flag, right? 

Or should it be opt-out?

For sure I think it should be default, to prevent such a thing, as a dracur shell is pretty intimidating.

Comment 1 Henning 2024-03-12 17:37:15 UTC

ping

Comment 2 Andrius Štikonas 2024-03-12 18:03:55 UTC

I would be a bit reluctant to force  it on for everybody without an ability to opt out

Perhaps we could add it to the list of available options in the mount point dialog? Right now it is not exposed at all, we only have
ro, users, noauto, noatime, nodiratime, sync, noexec and relative. Or is that not sufficient?

Comment 3 Henning 2024-03-13 21:40:55 UTC

I think that would be a good idea. I would pre-enable that though, as it can cause a lot of trouble

Comment 4 Andrius Štikonas 2024-04-04 00:08:08 UTC

Git commit 4232098e33115aad1e1174e87661214dffec6adb by Andrius Štikonas, on behalf of Thomas Bertels.
Committed on 04/04/2024 at 00:06.
Pushed by stikonas into branch 'master'.

Enable nofail by default for / and /home

Enable nofail by default when the mount point is / or /home
Apart from those, nofail mounts let the system boot normaly.

M  +4    -0    src/gui/editmountpointdialogwidget.cpp

https://invent.kde.org/system/partitionmanager/-/commit/4232098e33115aad1e1174e87661214dffec6adb

Comment 5 Thomas Bertels 2024-04-04 06:00:17 UTC

The are was a typo in the commit and the merge request, obviously, it's:

Enable nofail by default *except* for / and /home

Enable nofail by default *except* when the mount point is / or /home