Bug 475991

Summary: Search has shrink animation but no grow animation
Product: [Applications] systemsettings Reporter: tempqd <variable_valuables761>
Component: kcm_colorsAssignee: Plasma Bugs List <plasma-bugs-null>
Status: REOPENED ---    
Severity: minor CC: kde, nate, noahadvs, tantalising007, uhhadd
Priority: NOR    
Version First Reported In: master   
Target Milestone: ---   
Platform: unspecified   
OS: Unspecified   
Latest Commit: https://invent.kde.org/frameworks/kcmutils/-/commit/299ca139ebecf4d23b820f02884024aede910cba Version Fixed/Implemented In:
Sentry Crash Report:

Description tempqd 2023-10-23 04:39:22 UTC 
SUMMARY
When searching for color schemes (which, by the way, is this feature still necessary?), narrowing down the results makes themes shrink when disappearing. However, when more themes appear, they appear instantly with no animation.


STEPS TO REPRODUCE
1. Have Breeze Classic, Breeze Light, Breeze Dark themes
2. Search for "a" and watch Breeze Light shrink and disappear
3. Search for "ar" and watch Breeze Classic shrink and disappear, then Breeze Dark slide over to the first position
4. Search for "a" and watch Breeze Classic instantly appear at first position, while simultaneously Breeze Dark instantly appears at second position


EXPECTED RESULT
Step 4 should be Breeze Dark sliding over to second position, then Breeze Classic growing in the first position


Sorry about no screen recording!

OS: KDE Neon Unstable (2023 10 22)
Comment 1 Nate Graham 2023-10-23 20:48:01 UTC 
Can reproduce.
Comment 2 Nate Graham 2024-04-11 23:25:59 UTC 
*** Bug 484257 has been marked as a duplicate of this bug. ***
Comment 3 David Edmundson 2024-09-17 15:47:42 UTC 
Code is from KCMUtils.GridView, there is a removeAnimation but not insertion animation. I've made a patch to keep it in sync.

I feel we really only want animations for adding and deleting on explicit user actions, but not for searching - but it's not trivial to differentiate the two.
Comment 4 Bug Janitor Service 2024-09-17 15:49:43 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kcmutils/-/merge_requests/233
Comment 5 David Edmundson 2024-11-06 08:49:04 UTC 
Git commit 299ca139ebecf4d23b820f02884024aede910cba by David Edmundson.
Committed on 06/11/2024 at 08:46.
Pushed by davidedmundson into branch 'master'.

GridView: Add matching insertion animations

We have animations for removal, but not insert.
This patch makes it consistent.

M  +19   -0    src/qml/components/private/GridViewInternal.qml

https://invent.kde.org/frameworks/kcmutils/-/commit/299ca139ebecf4d23b820f02884024aede910cba
Comment 6 David Edmundson 2024-11-14 15:07:44 UTC 
Reverted ^