Bug 475906

Summary: Tapping the repeat button in now playing view shows extra text
Product: [Applications] Elisa Reporter: Justin Zobel <justin.zobel>
Component: generalAssignee: Matthieu Gallien <matthieu_gallien>
Status: ASSIGNED ---    
Severity: minor CC: jackhill3103, justin, nate
Priority: NOR    
Version First Reported In: 23.08.1   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Justin Zobel 2023-10-21 05:02:50 UTC 
SUMMARY
In the now playing view, tapping the repeat button has a prefix of "Current: ", which is redundant as you're pressing the button to change it.

STEPS TO REPRODUCE
1. Play a song
2. Open the Now Playing screen
3. Tap repeat icon

OBSERVED RESULT
The tooltip that appears is prefixed with "Current: ", which isn't useful, just the rest of the text which tells you which mode it was switched to.

EXPECTED RESULT
Just show the user the repeat mode that is now being used.

Elisa 23.08.1 on postmarketOS in mobile interface (Frameworks 5.110.0).

Note: This may be a toolkit issue, as the tooltip is likely displayed as it thinks the user is still hovering on the button.
Comment 1 Nate Graham 2023-10-23 21:18:42 UTC 
It's intentional right now to distinguish the text from the typical tooltip text which tells you what *will* happen when you click on a button. This button. Because it's a tri-state button that cycles through three modes when clicked, we reasoned that telling you the next mode would be confusing, and instead we should just tell you the current mode. And to make sure that you know it's telling you the current mode as opposed to the next one, we prefixed the text with "Current:"

Do you have an idea for what we could do instead?
Comment 2 Justin Zobel 2023-10-27 00:29:05 UTC 
It could be a popup like your recent change to let the user know a song is no longer available. Tooltip seems an odd area to let users know what it currently is.
Comment 3 Nate Graham 2023-10-27 00:45:22 UTC 
Maybe... but what would the tooltip for the button say?
Comment 4 Justin Zobel 2023-10-27 01:29:47 UTC 
So the popup would say what you just changed to. The button tooltip would indicate what you change to next, if you click it.
Comment 5 Nate Graham 2023-10-27 14:53:49 UTC 
Ok, I'll give it a try and see if it seems better.
Comment 6 Jack Hill 2023-10-27 15:16:34 UTC 
Are you saying that the tooltip shows *after* clicking the button? IMO the tooltip should only show when the button is being held down, and should disappear when the finger is released or is slid away. So I think the problem is that the tooltip doesn't disappear after releasing the button.
Comment 7 Bug Janitor Service 2023-10-28 19:06:19 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/511