Bug 475891

Summary: kfourinline 23.08.2
Product: [Applications] kfourinline Reporter: nilsbabcock73 <nilsbabcock73>
Component: generalAssignee: martin
Status: RESOLVED FIXED    
Severity: normal CC: ben, kde-games-bugs
Priority: NOR    
Version: 23.08.1   
Target Milestone: ---   
Platform: Debian stable   
OS: Linux   
Latest Commit: https://invent.kde.org/games/kfourinline/-/commit/a9281f5f7bbfcf54301492df466aafe4d03f7fc2 Version Fixed In:
Sentry Crash Report:

Description nilsbabcock73@gmail.com 2023-10-20 20:42:23 UTC 
SUMMARY

No changes to configure - kfourinline menu are kept. Game difficulty changes revert to default settings after clicking OK. Clicking on apply before clicking OK does nothing to correct the issue.

***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Bug Janitor Service 2023-10-22 22:58:38 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/games/kfourinline/-/merge_requests/13
Comment 2 Albert Astals Cid 2023-10-24 22:00:09 UTC 
Git commit 07fa7d0a23a33f32ab9c96976f38be2a6f608b38 by Albert Astals Cid.
Committed on 25/10/2023 at 00:00.
Pushed by aacid into branch 'master'.

Fix config dialog apply/ok not doing anything

If we set new buttons we create new buttons and the connects done in the
KConfigDialogPrivate constructor are lost.

Also, why set new buttons that hide the "Set defaults" button, let the
default button set of KConfigDialog shine :)

M  +0    -1    src/kwin4.cpp

https://invent.kde.org/games/kfourinline/-/commit/07fa7d0a23a33f32ab9c96976f38be2a6f608b38
Comment 3 Albert Astals Cid 2023-10-24 22:07:31 UTC 
Git commit a9281f5f7bbfcf54301492df466aafe4d03f7fc2 by Albert Astals Cid.
Committed on 25/10/2023 at 00:07.
Pushed by aacid into branch 'release/23.08'.

Fix config dialog apply/ok not doing anything

If we set new buttons we create new buttons and the connects done in the
KConfigDialogPrivate constructor are lost.

Also, why set new buttons that hide the "Set defaults" button, let the
default button set of KConfigDialog shine :)
(cherry picked from commit 07fa7d0a23a33f32ab9c96976f38be2a6f608b38)

M  +0    -1    src/kwin4.cpp

https://invent.kde.org/games/kfourinline/-/commit/a9281f5f7bbfcf54301492df466aafe4d03f7fc2