| Summary: | Quick-ungrouping a group with a mask may lead to data loss | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | paleh <paleh21669> |
| Component: | Layer Stack | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dimula73, wildcardc |
| Priority: | NOR | ||
| Version First Reported In: | 5.2.0 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/-/commit/f5f150972ebf57ade4dbfa3ce0bcd105f179c57b | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
paleh
2023-10-20 01:48:02 UTC
I can confirm this, it's indeed possible to lose layer data, and krita will even think the image is "unchanged" if you hit undo with just the right/wrong timing. The question is, what is the correct behaviour when ungrouping a group with more than one data layer and at least one mask layer? 1) Refuse to do so while mask layers are present 2) Drop the masks, possibly warn 3) Apply any mask to the topmost data layer in the group, or whichever data layer the mask is below (unintuitive) 4) Copy all masks to all data layers (safest but huge amount of duplication) Hm... here locally, just mere ungrouping of the group removes all the layers inside it :( Git commit 170b36b3c790a619046906e20a3dad208f7f520b by Dmitry Kazakov. Committed on 20/10/2023 at 16:56. Pushed by dkazakov into branch 'krita/5.2'. Don't allow ungrouping if the layers cannot be put into the parent layer Masks cannot be added to the root layer of the image, hence we shouldn't allow ungrouping a layers with masks into the root. M +32 -7 libs/ui/kis_node_manager.cpp https://invent.kde.org/graphics/krita/-/commit/170b36b3c790a619046906e20a3dad208f7f520b Git commit f5f150972ebf57ade4dbfa3ce0bcd105f179c57b by Dmitry Kazakov. Committed on 20/10/2023 at 16:57. Pushed by dkazakov into branch 'master'. Don't allow ungrouping if the layers cannot be put into the parent layer Masks cannot be added to the root layer of the image, hence we shouldn't allow ungrouping a layers with masks into the root. M +32 -7 libs/ui/kis_node_manager.cpp https://invent.kde.org/graphics/krita/-/commit/f5f150972ebf57ade4dbfa3ce0bcd105f179c57b |