Bug 475848

Summary:	Inconsistent UI elements used to open web links and in-app popups
Product:	[Applications] Discover	Reporter:	Nate Graham <nate>
Component:	discover	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aleixpol
Priority:	NOR	Keywords:	usability
Version First Reported In:	master
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/discover/-/commit/2b04c7afa3a939204530d3fc24822b22fc692103	Version Fixed/Implemented In:	6.2
Sentry Crash Report:
Attachments:	Wrong UI elements used

Description Nate Graham 2023-10-19 20:23:00 UTC

See attached screenshot. The red circled UI elements open links, while the blue-circled UI elements open in-app popups.

We should make sure that underlined links only open remote URLs in the web browser, and to open a pop-up in the app, we should use a button of some sort. Not the reverse.

It makes me sad to say this, because I designed the UI that I'm trashing now, but I think the inconsistency is a problem and makes it hard to predict what will happen when any of these things are clicked on.

Comment 1 Nate Graham 2023-10-20 20:28:01 UTC

Created attachment 162464 [details]
Wrong UI elements used

Comment 2 Bug Janitor Service 2023-10-20 20:52:10 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/668

Comment 3 Nate Graham 2024-08-02 15:49:09 UTC

Git commit 2b04c7afa3a939204530d3fc24822b22fc692103 by Nate Graham.
Committed on 02/08/2024 at 15:38.
Pushed by ngraham into branch 'master'.

Small redesign of ApplicationPage

Changes:
- Use buttons for things that perform actions within the app
- Use links for things that open external URLs
- Unify and improve spacing between logical groups
- Remove redundant app name in some headings

It's sort of unnecessarily huge sitting on the page, and there's plenty
of room for it up on the toolbar. This saves a bit of space on the page
and facilitates turning the other buttons on this row into underlined
links to make it clear that they will open a page in your browser.
FIXED-IN: 6.2

M  +180  -193  discover/qml/ApplicationPage.qml
M  +24   -53   discover/qml/ApplicationResourceButton.qml
M  +1    -3    libdiscover/backends/FlatpakBackend/qml/PermissionsList.qml
M  +1    -1    libdiscover/backends/PackageKitBackend/qml/PackageKitPermissions.qml

https://invent.kde.org/plasma/discover/-/commit/2b04c7afa3a939204530d3fc24822b22fc692103