Bug 475698

Summary: 5.2 missing new menu items if toolbars configured in 5.1
Product: [Applications] krita Reporter: Freya Lupen <penguinflyer2222>
Component: UsabilityAssignee: Halla Rempt <halla>
Status: RESOLVED FIXED    
Severity: normal CC: griffinvalley
Priority: NOR Keywords: release_blocker
Version: 5.2.1   
Target Milestone: ---   
Platform: Other   
OS: Other   
Latest Commit: https://invent.kde.org/graphics/krita/-/commit/01c04a957b396168affe83521c78af5e5d673660 Version Fixed In:
Sentry Crash Report:

Description Freya Lupen 2023-10-16 14:38:35 UTC 
SUMMARY
5.2.0 has krita5.xmlgui's version at 505, where 5.1.5 is 528 (and 5.1.6 (unreleased) is 529). Thus if the user configured toolbars in 5.1.5, creating a local xmlgui, it will have a higher version than 5.2.0's and override the newly added menu items.

STEPS TO REPRODUCE
1. Remove any existing krita5.xmlgui from the resource folder.
2. Save a toolbar configuration in 5.1.5.
3. Open 5.2.0.

OBSERVED RESULT
No new menu items.

EXPECTED RESULT
New menu items (Wrap Around Directions, Sample Screen Color, etc).

SOFTWARE/OS VERSIONS
Krita 5.2.0
Comment 1 wolthera 2023-10-16 19:38:27 UTC 
Halla, I'm assigning this to you because it is a very formal thing, and marked it as a release blocker so we can be sure it is fixed for 5.2.1.
Comment 2 Freya Lupen 2023-11-20 13:15:50 UTC 
This is still valid in 5.2.1, as its xmlgui version is 521, which is not greater than 5.1.5's 528.
Comment 3 Dmitry Kazakov 2023-12-06 10:52:03 UTC 
Git commit 01c04a957b396168affe83521c78af5e5d673660 by Dmitry Kazakov.
Committed on 06/12/2023 at 11:51.
Pushed by dkazakov into branch 'krita/5.2'.

Increase xmlgui version to be bigger that 5.1.6

5.1.6 -> 529
5.1.5 -> 528

M  +1    -1    krita/krita5.xmlgui

https://invent.kde.org/graphics/krita/-/commit/01c04a957b396168affe83521c78af5e5d673660