| Summary: | KPhotoAlbum crashes on clicking "Copy Image to ..." in Full screen preview in Annotations window | ||
|---|---|---|---|
| Product: | [Applications] kphotoalbum | Reporter: | Victor Lobo <victor.ip.lobo> |
| Component: | Viewer | Assignee: | KPhotoAlbum Bugs <kpabugs> |
| Status: | VERIFIED FIXED | ||
| Severity: | crash | CC: | tl |
| Priority: | NOR | ||
| Version: | 5.11.0 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/kphotoalbum/-/commit/c6c7df0d8cdb79a9e2ea49f88c1d181beabb6bae | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Victor Lobo
2023-10-13 23:47:03 UTC
Git commit 2516c6e6ba68fba2ba92d758124c726447bb6126 by Tobias Leupold. Committed on 14/10/2023 at 11:24. Pushed by tleupold into branch 'master'. Pass a deep copy of the file list to CopyLinkEngine M +3 -2 MainWindow/CopyLinkEngine.cpp M +3 -2 MainWindow/CopyLinkEngine.h https://invent.kde.org/graphics/kphotoalbum/-/commit/2516c6e6ba68fba2ba92d758124c726447bb6126 To be honest, I have no idea why this happens. Passing a deep copy of the file list instead of a reference to the CopyLinkEngine does fix it though. Maybe Johannes can explain why this happens?! After all, it's the very same as if it's triggered from the viewer directly, no?! Git commit 205a0f02baa2109e37ccb86781c2d6fb3a9d1dfd by Tobias Leupold. Committed on 14/10/2023 at 11:32. Pushed by tleupold into branch 'master'. Sadly not fixed. Use a const reference M +1 -1 MainWindow/CopyLinkEngine.cpp M +1 -2 MainWindow/CopyLinkEngine.h M +1 -1 Viewer/ViewerWidget.cpp https://invent.kde.org/graphics/kphotoalbum/-/commit/205a0f02baa2109e37ccb86781c2d6fb3a9d1dfd No, that didn't really fix it. One time, it works, one time, it crashes. Very strange. I now changed the CopyLinkEngine to use a const reference (as it should be), but I think, the problem is rather somewhere in the show quasi-fullscreen of the viewer, not in the CopyLinkEngine. I must admit that I'm a bit puzzled atm … :-( Git commit c6c7df0d8cdb79a9e2ea49f88c1d181beabb6bae by Johannes Zarl-Zierl. Committed on 14/10/2023 at 23:33. Pushed by johanneszarl into branch 'master'. Restrict set of context menu actions available in annotation dialog's fullscreen preview This also removes the copy/link actions that caused the crash in bug #475585, which should never have been available at this place in the program. M +1 -1 AnnotationDialog/Dialog.cpp M +3 -0 CHANGELOG.md M +5 -4 MainWindow/Window.cpp M +84 -45 Viewer/ViewerWidget.cpp M +6 -3 Viewer/ViewerWidget.h https://invent.kde.org/graphics/kphotoalbum/-/commit/c6c7df0d8cdb79a9e2ea49f88c1d181beabb6bae That fixes the crash. Thanks! |