Bug 475573

Summary:	"Hide" button on the ToolBar does not synchronize checked state with Tools->Annotations menu item
Product:	[Applications] okular	Reporter:	ratijas <me>
Component:	general	Assignee:	Okular developers <okular-devel>
Status:	CONFIRMED ---
Severity:	minor	CC:	nate
Priority:	NOR
Version First Reported In:	23.08.1
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description ratijas 2023-10-13 15:34:01 UTC

SUMMARY

ToolBar with annotation options has a "Hide" button that closes it (with no obvious telling where it has gone to or how to reopen it btw, but that's a different story). That button hides the toolbar without synchronizing the checked state of the related Tools->Annotations menu item. The menu item basically toggles the toolbar instead of showing or hiding it according to the checked state.

STEPS TO REPRODUCE
1. Open Okular
2. Hide annotations toolbar by clicking the red cross button on its trailing (right) side.
3. Open Tools menu

OBSERVED RESULT
Annotations item is still checked, while the toolbar is now invisible.

EXPECTED RESULT
Annotations menu item should be in-sync with toolbar's actual visibility.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.27.80
KDE Frameworks Version: 5.240.0
Qt Version: 6.6.0
Kernel Version: 6.5.7-arch1-1 (64-bit)
Graphics Platform: X11

Comment 1 ratijas 2023-10-13 16:18:06 UTC

ah of course, everything surrounding this action in AnnotationActionHandler class is marked with a comment

// action group workaround