Bug 475336

Summary: Scale to new size in animation make some image layers with transform mask gone, but I still see that in timeline
Product: [Applications] krita Reporter: lizard_olmighty <harrynft>
Component: AnimationAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED DUPLICATE    
Severity: normal CC: emmetoneill.pdx, marmaladeplan3t
Priority: NOR    
Version First Reported In: 5.2.0   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description lizard_olmighty 2023-10-07 19:07:55 UTC
When I scale image size in animation, I lost image in layers with transform mask. Or maybe move outside my canvas? 





SOFTWARE/OS VERSIONS
Windows: 11
Krita 5.2

ADDITIONAL INFORMATION
Comment 1 Redkitt3n14 2023-10-07 22:50:09 UTC
Hello, I'm not here to help, I'm just moving between my 2 bug reports 1 by 1. This is the 2nd Krita report I have found, however it is rather funny that it is about animating and transforms, as both my bugs are due to animations and transform masks conflicting. I wish you well.
Comment 2 Emmet O'Neill 2025-06-05 23:28:23 UTC
This appears to be the same problem as described in 469881, and I'm working towards a solution now.

*** This bug has been marked as a duplicate of bug 469881 ***
Comment 3 Emmet O'Neill 2025-06-11 22:57:58 UTC
Git commit 1d04a5f2f4cb8924b35d73cae448e86aefbb5e75 by Emmet O'Neill.
Committed on 11/06/2025 at 22:52.
Pushed by emmetoneill into branch 'master'.

BUGFIX: Fixed incorrect scaling of animated transform mask values.

It seems that when scaling a canvas that contains an
animated transform mask, the transform parameter scaling
function was creating new keyframes out of the previously
interpolated in-between values, which was causing
the transform mask to act in an unpredictable and
undesirable way.

Now we simply scale the scalar keyframes as needed.
Related: bug 469881

M  +0    -2    plugins/tools/tool_transform2/KisAnimatedTransformMaskParamsHolder.cpp

https://invent.kde.org/graphics/krita/-/commit/1d04a5f2f4cb8924b35d73cae448e86aefbb5e75
Comment 4 Emmet O'Neill 2025-06-18 23:54:26 UTC
Git commit 1c04b47b35a188bb073740b1ff399767a523d41e by Emmet O'Neill.
Committed on 18/06/2025 at 23:53.
Pushed by emmetoneill into branch 'krita/5.2'.

BUGFIX: Fixed incorrect scaling of animated transform mask values.

It seems that when scaling a canvas that contains an
animated transform mask, the transform parameter scaling
function was creating new keyframes out of the previously
interpolated in-between values, which was causing
the transform mask to act in an unpredictable and
undesirable way.

Now we simply scale the scalar keyframes as needed.
Related: bug 469881
(cherry picked from commit 1d04a5f2f4cb8924b35d73cae448e86aefbb5e75)

M  +0    -2    plugins/tools/tool_transform2/KisAnimatedTransformMaskParamsHolder.cpp

https://invent.kde.org/graphics/krita/-/commit/1c04b47b35a188bb073740b1ff399767a523d41e