Bug 474864

Summary: Kirigami.AboutPage donateUrl not hooked up properly
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: Luis B <luis.buechi>
Component: generalAssignee: kdelibs bugs <kdelibs-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: me, notmart
Priority: NOR    
Version First Reported In: 5.110.0   
Target Milestone: Not decided   
Platform: Manjaro   
OS: Linux   
Latest Commit: https://invent.kde.org/frameworks/kirigami/-/commit/fab1e528dc868d7c5a785a4ea558afdb9a422c68 Version Fixed/Implemented In: 5.111
Sentry Crash Report:

Description Luis B 2023-09-25 16:56:35 UTC 
SUMMARY
Kirigami.AboutPage doesn't forward "donateUrl" to Kirigami.AboutItem making it impossible to set it from the outside


STEPS TO REPRODUCE
1. Create a Kirigami.AboutPage
2. set "donateUrl" to something (or even undefined)
3. Observe nothing changing in the created about page

OBSERVED RESULT
When trying to unset the Donate URL (by setting "donateUrl: undefined") nothing happens

EXPECTED RESULT
The "Donate" URL Button goes away.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma:
KDE Plasma Version: 5.27.8
KDE Frameworks Version: 5.110
Qt Version: 5.15.10

ADDITIONAL INFORMATION
Can be somewhat circumvented if all one wants is to remove the Donate link by making the app id (KAboutData::desktopFilePath) not start with "org.kde." as that is what makes it default to a KDE donate link as opposed to an empty string.
Still doesn't allow for setting a custom URL of course.
Comment 2 ratijas 2023-09-26 18:11:35 UTC 
Git commit f4cfbc30dc876a4bea1226c6c90ae39096a31140 by ivan tkachenko.
Committed on 26/09/2023 at 17:29.
Pushed by ratijas into branch 'master'.

AboutPage: Allow overriding donateUrl by aliasing it from AboutItem

It was an omission that other properties here were already aliases while
donateUrl binding was simply duplicated without any connections in between.
FIXED-IN: 5.111

M  +1    -1    src/controls/AboutPage.qml

https://invent.kde.org/frameworks/kirigami/-/commit/f4cfbc30dc876a4bea1226c6c90ae39096a31140
Comment 3 ratijas 2023-09-26 18:12:14 UTC 
Git commit fab1e528dc868d7c5a785a4ea558afdb9a422c68 by ivan tkachenko.
Committed on 26/09/2023 at 20:12.
Pushed by ratijas into branch 'kf5'.

AboutPage: Allow overriding donateUrl by aliasing it from AboutItem

It was an omission that other properties here were already aliases while
donateUrl binding was simply duplicated without any connections in between.
FIXED-IN: 5.111
(cherry picked from commit f4cfbc30dc876a4bea1226c6c90ae39096a31140)

M  +1    -1    src/controls/AboutPage.qml

https://invent.kde.org/frameworks/kirigami/-/commit/fab1e528dc868d7c5a785a4ea558afdb9a422c68