Bug 474838

Summary: ELF structure definition e_phoff array should be named "Program headers"
Product: [Applications] okteta Reporter: Alex Hudspith <alexh.public+kde>
Component: Structures ToolAssignee: Alex Richardson <arichardson.kde>
Status: RESOLVED FIXED    
Severity: normal CC: kossebau
Priority: NOR    
Version First Reported In: 0.26.7   
Target Milestone: ---   
Platform: unspecified   
OS: Unspecified   
Latest Commit: Version Fixed/Implemented In: 0.26.14
Sentry Crash Report:

Description Alex Hudspith 2023-09-24 19:38:35 UTC
SUMMARY
kasten/controllers/view/structures/examples/okteta/structures/elf/main.osd

In this ELF structure definition, the arrays under both e_phoff and e_shoff are called "Section headers".
e_shoff is correct, but e_phoff should be "Program headers".

Reference: https://refspecs.linuxfoundation.org/elf/gabi4+/ch4.eheader.html

STEPS TO REPRODUCE
1.  Open any ELF file
2. Open the Structures tool view
3. Expand Elf32_Ehdr > e_phoff and e_shoff

OBSERVED RESULT
Both arrays are called "Section headers".

EXPECTED RESULT
e_phoff array should be called "Program headers".

SOFTWARE/OS VERSIONS
Linux: Kubuntu 22.04
KDE Plasma: 5.24.7
Comment 1 Friedrich W. H. Kossebau 2023-12-03 17:44:35 UTC
Git commit 418e94ec7774a12671e0742dbcf4f270f26ad83f by Friedrich W. H. Kossebau.
Committed on 03/12/2023 at 17:33.
Pushed by kossebau into branch '0.26'.

ELF structure definition: fix wrong e_phoff label
FIXED-IN: 0.26.14

M  +1    -1    kasten/controllers/view/structures/examples/okteta/structures/elf/main.osd

https://invent.kde.org/utilities/okteta/-/commit/418e94ec7774a12671e0742dbcf4f270f26ad83f
Comment 2 Friedrich W. H. Kossebau 2023-12-03 17:50:42 UTC
Thanks for the report :)