| Summary: | Recent files search is case sensitive | ||
|---|---|---|---|
| Product: | [Plasma] krunner | Reporter: | Michael D <nortexoid> |
| Component: | general | Assignee: | Alexander Lohnau <alexander.lohnau> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alexander.lohnau, gersonfjunior, natalie_clarius, nate |
| Priority: | NOR | ||
| Version First Reported In: | 6.1.5 | ||
| Target Milestone: | --- | ||
| Platform: | Manjaro | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/0a22f4635dc8739e31b93e9633d287d06dd6ae8a | Version Fixed/Implemented In: | 5.27.9 |
| Sentry Crash Report: | |||
| Attachments: |
Recent documents runner does find query anywhere in file name
It's case insensitive |
||
|
Description
Michael D
2023-09-22 06:55:57 UTC
Created attachment 161805 [details]
Recent documents runner does find query anywhere in file name
Can't reproduce:
And looking at the code I don't see what could cause this. Michael, could you please post a screenshot of the issue? Sorry, the problem is not what I thought it was. The problem is that search is case sensitive. If the file is called "Carroll and the Tortoise.pdf" and I search "tortoise", it won't return a result, but I will if I type "Tortoise". I think this is a bug in any case as a search for recent files shouldn't be case sensitive. Oh well, you are right. Looking at the API, it does not offer a case sensitivity option :/ This will need a bit of work/thinking. Most likely it will target Plasma 6. Created attachment 161811 [details]
It's case insensitive
Can't reproduce that either; here's a screenshot of a Recent Files match that's case insensitive.
(In reply to Nate Graham from comment #6) > Created attachment 161811 [details] > It's case insensitive > > Can't reproduce that either; here's a screenshot of a Recent Files match > that's case insensitive. It's insensitive after the first character, which I forgot to mention... That is perfect analysis! While optimizing some code, I noticed the condition that we run into. I'll make a MR shortly to make a backportable fix. Awesome, thanks! A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3332 Git commit 28ced0e1e0bc5f62f107b3e6871fda60277297e8 by Alexander Lohnau. Committed on 25/09/2023 at 14:52. Pushed by alex into branch 'master'. runners/recentdocuments: Fix results being discarded when casing is different Regression from ecfc27c245a84085127982b43af92b8148740922 Test Plan: - Create a file called MyTextFile.txt - Open it in any KDE app so it is in the recent files list - "MyTextFile" should work as before and provide the result - "textfile" as a query should only provide a result with this change M +1 -1 runners/recentdocuments/recentdocuments.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/28ced0e1e0bc5f62f107b3e6871fda60277297e8 Git commit 0a22f4635dc8739e31b93e9633d287d06dd6ae8a by Alexander Lohnau. Committed on 25/09/2023 at 19:33. Pushed by alex into branch 'Plasma/5.27'. runners/recentdocuments: Fix results being discarded when casing is different FIXED-IN: 5.27.9 Regression from ecfc27c245a84085127982b43af92b8148740922 Test Plan: - Create a file called MyTextFile.txt - Open it in any KDE app so it is in the recent files list - "MyTextFile" should work as before and provide the result - "textfile" as a query should only provide a result with this change Cherry-picked from 28ced0e1e0bc5f62f107b3e6871fda60277297e8 M +1 -1 runners/recentdocuments/recentdocuments.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/0a22f4635dc8739e31b93e9633d287d06dd6ae8a I couldn't cherry-pick in GitLab directly and resolved the conflict locally. Hence the slight delay and adjustment of FIXED-IN version ;) This bug is marked as fixed, but I'm seeing it on Manjaro running Plasma 6.1.5. The file search is fully case-sensitive on krunner, but on the terminal baloosearch works as expected. |