Bug 474754

Summary: Selecting files with Ctrl, Shift+Click in Git sidebar shouldn't open diff
Product: [Applications] kate Reporter: Grósz Dániel <groszdanielpub>
Component: generalAssignee: KWrite Developers <kwrite-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version First Reported In: 23.08.0   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: https://invent.kde.org/utilities/kate/-/commit/d3a0f60b3cf97ef2dfef78c1ce9612e0ae3055d0 Version Fixed/Implemented In:
Sentry Crash Report:

Description Grósz Dániel 2023-09-21 03:53:56 UTC 
SUMMARY
Selecting multiple files in the Git sidebar with Ctrl+Click is useful to e.g. stage them all using the context menu. However, it's currently inconvenient because a click also executes the configured single click action (Show Diff by default) even if Ctrl or Shift is pressed.

STEPS TO REPRODUCE
1. In the Git sidebar, Ctrl+Click or Shift+Click on a file.

OBSERVED RESULT
It becomes selected (or deselected if it's already selected, and in the case of Shift+Click some other files become selected), and the single click action is performed on the file clicked.

EXPECTED RESULT
The selection is changed, but the single click action isn't performed.

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20230915
KDE Plasma Version: 5.27.8
KDE Frameworks Version: 5.110.0
Qt Version: 5.15.10
Kernel Version: 6.4.11-1-default (64-bit)
Graphics Platform: X11
Comment 1 Waqar Ahmed 2023-11-20 10:53:08 UTC 
Git commit d3a0f60b3cf97ef2dfef78c1ce9612e0ae3055d0 by Waqar Ahmed.
Committed on 20/11/2023 at 11:52.
Pushed by waqar into branch 'master'.

git: Ignore single/double click if a modifier is held

M  +7    -2    addons/project/gitwidget.cpp

https://invent.kde.org/utilities/kate/-/commit/d3a0f60b3cf97ef2dfef78c1ce9612e0ae3055d0