| Summary: | With a large window, clicking multiple apps on Discover's home page pushes each one as a new column | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Patrick Silva <bugseforuns> |
| Component: | discover | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aleixpol, matej.starc, me, nate |
| Priority: | NOR | Keywords: | qt6, regression |
| Version First Reported In: | master | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/kirigami/-/commit/c871893587f71aff9b0c8b26c26e5754fd09e251 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | screen recording | ||
Can confirm. If you keep clicking on apps, it pushes more pages! Might be caused by recent ColumnView changes. CCing some folks. Git commit c871893587f71aff9b0c8b26c26e5754fd09e251 by Marco Martin. Committed on 26/09/2023 at 17:25. Pushed by mart into branch 'master'. Restore push behavior, unbreak existing apps The behavior of PageRow is alike a browser history of undo stack: the top of the stack is considered the page the app is currently in, rather than the total depth. This logic broke in the refactor, causing many apps like multi level KCMS or discover to do double pushes keeping creating new pages in the row. this does the minimal indexes fix to make the existing users behave correctly. M +37 -4 autotests/tst_pagerow.qml M +4 -1 src/columnview.cpp M +5 -3 src/controls/PageRow.qml https://invent.kde.org/frameworks/kirigami/-/commit/c871893587f71aff9b0c8b26c26e5754fd09e251 |
Created attachment 161631 [details] screen recording STEPS TO REPRODUCE 1. open Discover 2. click on any app 3. click on another app OBSERVED RESULT the description pages of the clicked apps opened next to each other. Please watch the attached screen recording. EXPECTED RESULT the observed result should not occur SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.27.80 KDE Frameworks Version: 5.240.0 Qt Version: 6.6.0 Graphics Platform: Wayland