Bug 474532

Summary: Git sidebar: error message after cancelling Open Commit
Product: [Applications] kate Reporter: Frank Steinmetzger <dev-kde>
Component: applicationAssignee: KWrite Developers <kwrite-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 23.08.0   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: https://invent.kde.org/utilities/kate/-/commit/3f0740a602948e5294455856955311e5e0726668 Version Fixed In:

Description Frank Steinmetzger 2023-09-14 22:47:38 UTC 
STEPS TO REPRODUCE
1. Open a git-managed file in Kate
2. Open the Git sidebar
3. From the Tools button, select “Open Commit…”
4. Click on “Cancel”

OBSERVED RESULT
The log view shows a new Git error with “invalid hash”

So apparently even though I pressed cancel, Git is still called. When I input a valid commit ID and press Cancel, I still get the error message.

EXPECTED RESULT
Cancel means “do nothing”, so there should be no error message.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.27.7
KDE Frameworks Version: 5.109.0
Comment 1 Waqar Ahmed 2023-09-15 06:33:25 UTC 
Git commit 3f0740a602948e5294455856955311e5e0726668 by Waqar Ahmed.
Committed on 15/09/2023 at 08:33.
Pushed by waqar into branch 'master'.

Git: Dont show error on cancelling open commit

M  +6    -3    addons/project/gitwidget.cpp

https://invent.kde.org/utilities/kate/-/commit/3f0740a602948e5294455856955311e5e0726668