Bug 474391

Summary: in Merge imported operations, prefer fields with values over blank fields
Product: [Applications] skrooge Reporter: skierpage <info>
Component: generalAssignee: Stephane MANKOWSKI <stephane>
Status: RESOLVED FIXED    
Severity: minor    
Priority: NOR    
Version First Reported In: 2.30.0   
Target Milestone: 25.1.0   
Platform: Flatpak   
OS: Linux   
Latest Commit: https://invent.kde.org/office/skrooge/-/commit/255d0909cea56670725a7c54dbe96abae9d36139 Version Fixed/Implemented In:
Sentry Crash Report:

Description skierpage 2023-09-10 23:48:18 UTC 
SUMMARY
Skrooge's Merge imported operations action prefers the Payee from the manual transaction over the Payee from the imported operation, even if the manual Payee is blank. 


STEPS TO REPRODUCE
1. Have a manually-entered operation with no Payee, and an imported operation with a payee. (I think I got in this state when I made the operation in another account into a transfer into this account.)
2. Select both in an Operations tab and right-click choose Merge imported operations

OBSERVED RESULT
The Payee from the manual transaction "wins", even though it is blank.

EXPECTED RESULT
The logic should be "Prefer the field's value from the manual transaction, unless that one is blank."

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
KDE Plasma Version: 5.27.7
KDE Frameworks Version: 5.109.0
Qt Version: 5.15.10 Wayland

ADDITIONAL INFORMATION
Comment 1 Stephane MANKOWSKI 2023-10-01 20:34:09 UTC 
Git commit 255d0909cea56670725a7c54dbe96abae9d36139 by Stephane MANKOWSKI.
Committed on 01/10/2023 at 22:34.
Pushed by smankowski into branch 'master'.

in Merge imported operations, prefer fields with values over blank fields

M  +4    -0    CHANGELOG
M  +4    -1    skgbankmodeler/skgoperationobject.cpp
M  +1    -1    tests/skgbankmodelertest/skgtestimportqif2.cpp

https://invent.kde.org/office/skrooge/-/commit/255d0909cea56670725a7c54dbe96abae9d36139